From ab3aa0759a99a35f8920e2de39dec81d39fc24e0 Mon Sep 17 00:00:00 2001 From: Itamar Date: Sun, 27 Jun 2021 21:46:23 +0300 Subject: LanguageServers: Don't VERIFY that set_todo_entries callback exists The callback may not exist if the CodeComprehensionEngine is running in the context of tests (i.e CppLanguageServer -t). --- .../DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'Userland/DevTools/HackStudio') diff --git a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp index aec90ce5af..37093fc2ab 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp +++ b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp @@ -19,6 +19,7 @@ CodeComprehensionEngine::~CodeComprehensionEngine() } void CodeComprehensionEngine::set_declarations_of_document(const String& filename, Vector&& declarations) { + // Callback may not be configured if we're running tests if (!set_declarations_of_document_callback) return; @@ -34,7 +35,9 @@ void CodeComprehensionEngine::set_declarations_of_document(const String& filenam void CodeComprehensionEngine::set_todo_entries_of_document(String const& filename, Vector&& todo_entries) { - VERIFY(set_todo_entries_of_document_callback); + // Callback may not be configured if we're running tests + if (!set_todo_entries_of_document_callback) + return; set_todo_entries_of_document_callback(filename, move(todo_entries)); } -- cgit v1.2.3