From cb0b82ec464f28fae134403fc268961c02f27e1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= <filmroellchen@serenityos.org>
Date: Tue, 30 Aug 2022 12:49:08 +0200
Subject: Userland+LibCore: Remove legacy SERENITY_VERSION from Core::Version

This was being used as a default version argument in a couple of APIs,
so those need to change signature and the caller always needs to provide
a version.
---
 Userland/Applications/About/main.cpp            | 2 +-
 Userland/Applications/Browser/BrowserWindow.cpp | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

(limited to 'Userland/Applications')

diff --git a/Userland/Applications/About/main.cpp b/Userland/Applications/About/main.cpp
index 0cc6a5949c..b0d13322fd 100644
--- a/Userland/Applications/About/main.cpp
+++ b/Userland/Applications/About/main.cpp
@@ -21,6 +21,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
     TRY(Core::System::unveil(nullptr, nullptr));
 
     auto app_icon = TRY(GUI::Icon::try_create_default_icon("ladyball"sv));
-    GUI::AboutDialog::show("SerenityOS"sv, app_icon.bitmap_for_size(32), nullptr, app_icon.bitmap_for_size(16), Core::Version::read_long_version_string());
+    GUI::AboutDialog::show("SerenityOS"sv, Core::Version::read_long_version_string(), app_icon.bitmap_for_size(32), nullptr, app_icon.bitmap_for_size(16));
     return app->exec();
 }
diff --git a/Userland/Applications/Browser/BrowserWindow.cpp b/Userland/Applications/Browser/BrowserWindow.cpp
index 292cced932..a1cfe695b2 100644
--- a/Userland/Applications/Browser/BrowserWindow.cpp
+++ b/Userland/Applications/Browser/BrowserWindow.cpp
@@ -18,6 +18,7 @@
 #include <LibConfig/Client.h>
 #include <LibCore/StandardPaths.h>
 #include <LibCore/Stream.h>
+#include <LibCore/Version.h>
 #include <LibGUI/AboutDialog.h>
 #include <LibGUI/Application.h>
 #include <LibGUI/Clipboard.h>
@@ -128,7 +129,7 @@ BrowserWindow::BrowserWindow(CookieJar& cookie_jar, URL url)
 
     m_window_actions.on_about = [this] {
         auto app_icon = GUI::Icon::default_icon("app-browser"sv);
-        GUI::AboutDialog::show("Browser"sv, app_icon.bitmap_for_size(32), this);
+        GUI::AboutDialog::show("Browser"sv, Core::Version::read_long_version_string(), app_icon.bitmap_for_size(32), this);
     };
 
     m_window_actions.on_show_bookmarks_bar = [](auto& action) {
-- 
cgit v1.2.3