From e7f5b5a2f381e7677429edc8320d0257ef7fc1c7 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 16 Apr 2023 19:48:40 +0200 Subject: LibWeb: Fix multi-line flex column layouts with auto height on container When sizing a flex container with flex-direction:column under a max-content height constraint, we were incorrectly truncating the infinite available height to 0 when collecting flex items into lines. This caused us to put every flex item in its own flex line, which is the complete opposite of what we want during max-content intrinsic sizing, as the layout would grow wide but not tall. --- .../multi-line-column-container-with-automatic-height.txt | 7 +++++++ ...multi-line-column-container-with-automatic-height.html | 15 +++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 Tests/LibWeb/Layout/expected/flex/multi-line-column-container-with-automatic-height.txt create mode 100644 Tests/LibWeb/Layout/input/flex/multi-line-column-container-with-automatic-height.html (limited to 'Tests') diff --git a/Tests/LibWeb/Layout/expected/flex/multi-line-column-container-with-automatic-height.txt b/Tests/LibWeb/Layout/expected/flex/multi-line-column-container-with-automatic-height.txt new file mode 100644 index 0000000000..50b55e2e3c --- /dev/null +++ b/Tests/LibWeb/Layout/expected/flex/multi-line-column-container-with-automatic-height.txt @@ -0,0 +1,7 @@ +Viewport <#document> at (0,0) content-size 800x600 children: not-inline + BlockContainer at (1,1) content-size 798x176 children: not-inline + BlockContainer at (10,10) content-size 780x158 children: not-inline + Box at (11,11) content-size 200x156 flex-container(column) children: not-inline + BlockContainer

at (12,12) content-size 50x50 flex-item children: not-inline + BlockContainer

at (12,64) content-size 50x50 flex-item children: not-inline + BlockContainer

at (12,116) content-size 50x50 flex-item children: not-inline diff --git a/Tests/LibWeb/Layout/input/flex/multi-line-column-container-with-automatic-height.html b/Tests/LibWeb/Layout/input/flex/multi-line-column-container-with-automatic-height.html new file mode 100644 index 0000000000..2df2347fbe --- /dev/null +++ b/Tests/LibWeb/Layout/input/flex/multi-line-column-container-with-automatic-height.html @@ -0,0 +1,15 @@ +

\ No newline at end of file -- cgit v1.2.3