From 6f52272d34baa4c6da2e0976a05ba71beec67eb5 Mon Sep 17 00:00:00 2001 From: martinfalisse Date: Sat, 1 Apr 2023 19:09:19 +0200 Subject: LibWeb: Fix regression in definite grid row heights Fixes a row height bug when a grid item in a row has a definite height. --- Tests/LibWeb/Layout/expected/grid/row-height.txt | 34 ++++++++++++++++++++++++ Tests/LibWeb/Layout/input/grid/row-height.html | 22 +++++++++++++++ 2 files changed, 56 insertions(+) create mode 100644 Tests/LibWeb/Layout/expected/grid/row-height.txt create mode 100644 Tests/LibWeb/Layout/input/grid/row-height.html (limited to 'Tests') diff --git a/Tests/LibWeb/Layout/expected/grid/row-height.txt b/Tests/LibWeb/Layout/expected/grid/row-height.txt new file mode 100644 index 0000000000..caa97fd2e4 --- /dev/null +++ b/Tests/LibWeb/Layout/expected/grid/row-height.txt @@ -0,0 +1,34 @@ +Viewport <#document> at (0,0) content-size 800x600 children: not-inline + BlockContainer at (0,0) content-size 800x83.46875 children: not-inline + BlockContainer at (8,8) content-size 784x67.46875 children: not-inline + Box at (8,8) content-size 784x67.46875 children: not-inline + BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline + TextNode <#text> + BlockContainer at (8,8) content-size 392.140625x50 children: inline + line 0 width: 6.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 1, rect: [8,8 6.34375x17.46875] + "1" + TextNode <#text> + BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline + TextNode <#text> + BlockContainer at (400.140625,8) content-size 392x50 children: inline + line 0 width: 8.8125, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 1, rect: [400.140625,8 8.8125x17.46875] + "2" + TextNode <#text> + BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline + TextNode <#text> + BlockContainer at (8,58) content-size 392.140625x17.46875 children: inline + line 0 width: 9.09375, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 1, rect: [8,58 9.09375x17.46875] + "3" + TextNode <#text> + BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline + TextNode <#text> + BlockContainer at (400.140625,58) content-size 392x17.46875 children: inline + line 0 width: 7.75, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 1, rect: [400.140625,58 7.75x17.46875] + "4" + TextNode <#text> + BlockContainer <(anonymous)> at (8,8) content-size 0x0 children: inline + TextNode <#text> diff --git a/Tests/LibWeb/Layout/input/grid/row-height.html b/Tests/LibWeb/Layout/input/grid/row-height.html new file mode 100644 index 0000000000..a1fb174fc0 --- /dev/null +++ b/Tests/LibWeb/Layout/input/grid/row-height.html @@ -0,0 +1,22 @@ + + + +
+
1
+
2
+
3
+
4
+
\ No newline at end of file -- cgit v1.2.3