From 8b4cc07a54fac34c3cf19d365fc404892c8b9aad Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 7 Sep 2022 15:27:08 +0100 Subject: LibIDL+WrapperGenerator: Implement Type::is_distinguishable_from() As part of this, I've moved a couple of methods for checking for null/undefined from UnionType to Type, and filled in more of their steps. This now detects more, and so causes us to hit a `TODO()` which is too big for me to go after right now, so I've replaced that assertion with a log message. --- .../Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Meta') diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp index a760c7b56b..f4e1345572 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp @@ -1019,7 +1019,7 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter // FIXME: 2. If the union type includes a nullable type and V is null or undefined, then return the IDL value null. if (union_type.includes_nullable_type()) { - TODO(); + dbgln("FIXME: 2. If the union type includes a nullable type and V is null or undefined, then return the IDL value null."); } else if (dictionary_type) { // 4. If V is null or undefined, then // 4.1 If types includes a dictionary type, then return the result of converting V to that dictionary type. -- cgit v1.2.3