From 4a81b33c07cbb440c7fefcc073e94e113feeac52 Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Sat, 4 Dec 2021 10:09:09 +0100 Subject: Everywhere: Fix -Winconsistent-missing-override warnings from Clang This option is already enabled when building Lagom, so let's enable it for the main build too. We will no longer be surprised by Lagom Clang CI builds failing while everything compiles locally. Furthermore, the stronger `-Wsuggest-override` warning is enabled in this commit, which enforces the use of the `override` keyword in all classes, not just those which already have some methods marked as `override`. This works with both GCC and Clang. --- Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Meta/Lagom/Tools') diff --git a/Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp b/Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp index 0abc3bc693..b3d47c1f8d 100644 --- a/Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp @@ -416,7 +416,7 @@ public: )~~~"); message_generator.append(R"~~~( - virtual bool valid() const { return m_ipc_message_valid; } + virtual bool valid() const override { return m_ipc_message_valid; } virtual IPC::MessageBuffer encode() const override { -- cgit v1.2.3