From cf16b2c8e64709d570c5f54a981017d217e95ed0 Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Tue, 23 Aug 2022 17:58:05 +0200
Subject: Kernel: Wrap process address spaces in SpinlockProtected

This forces anyone who wants to look into and/or manipulate an address
space to lock it. And this replaces the previous, more flimsy, manual
spinlock use.

Note that pointers *into* the address space are not safe to use after
you unlock the space. We've got many issues like this, and we'll have
to track those down as wlel.
---
 Kernel/ProcessSpecificExposed.cpp | 78 ++++++++++++++++++++-------------------
 1 file changed, 40 insertions(+), 38 deletions(-)

(limited to 'Kernel/ProcessSpecificExposed.cpp')

diff --git a/Kernel/ProcessSpecificExposed.cpp b/Kernel/ProcessSpecificExposed.cpp
index 1bda213e5c..2e4cea6c29 100644
--- a/Kernel/ProcessSpecificExposed.cpp
+++ b/Kernel/ProcessSpecificExposed.cpp
@@ -267,45 +267,47 @@ ErrorOr<void> Process::procfs_get_fds_stats(KBufferBuilder& builder) const
 ErrorOr<void> Process::procfs_get_virtual_memory_stats(KBufferBuilder& builder) const
 {
     auto array = TRY(JsonArraySerializer<>::try_create(builder));
-    TRY(address_space().region_tree().with([&](auto& region_tree) -> ErrorOr<void> {
-        for (auto const& region : region_tree.regions()) {
-            auto current_process_credentials = Process::current().credentials();
-            if (!region.is_user() && !current_process_credentials->is_superuser())
-                continue;
-            auto region_object = TRY(array.add_object());
-            TRY(region_object.add("readable"sv, region.is_readable()));
-            TRY(region_object.add("writable"sv, region.is_writable()));
-            TRY(region_object.add("executable"sv, region.is_executable()));
-            TRY(region_object.add("stack"sv, region.is_stack()));
-            TRY(region_object.add("shared"sv, region.is_shared()));
-            TRY(region_object.add("syscall"sv, region.is_syscall_region()));
-            TRY(region_object.add("purgeable"sv, region.vmobject().is_anonymous()));
-            if (region.vmobject().is_anonymous()) {
-                TRY(region_object.add("volatile"sv, static_cast<Memory::AnonymousVMObject const&>(region.vmobject()).is_volatile()));
-            }
-            TRY(region_object.add("cacheable"sv, region.is_cacheable()));
-            TRY(region_object.add("address"sv, region.vaddr().get()));
-            TRY(region_object.add("size"sv, region.size()));
-            TRY(region_object.add("amount_resident"sv, region.amount_resident()));
-            TRY(region_object.add("amount_dirty"sv, region.amount_dirty()));
-            TRY(region_object.add("cow_pages"sv, region.cow_pages()));
-            TRY(region_object.add("name"sv, region.name()));
-            TRY(region_object.add("vmobject"sv, region.vmobject().class_name()));
-
-            StringBuilder pagemap_builder;
-            for (size_t i = 0; i < region.page_count(); ++i) {
-                auto page = region.physical_page(i);
-                if (!page)
-                    pagemap_builder.append('N');
-                else if (page->is_shared_zero_page() || page->is_lazy_committed_page())
-                    pagemap_builder.append('Z');
-                else
-                    pagemap_builder.append('P');
+    TRY(address_space().with([&](auto& space) {
+        return space->region_tree().with([&](auto& region_tree) -> ErrorOr<void> {
+            for (auto const& region : region_tree.regions()) {
+                auto current_process_credentials = Process::current().credentials();
+                if (!region.is_user() && !current_process_credentials->is_superuser())
+                    continue;
+                auto region_object = TRY(array.add_object());
+                TRY(region_object.add("readable"sv, region.is_readable()));
+                TRY(region_object.add("writable"sv, region.is_writable()));
+                TRY(region_object.add("executable"sv, region.is_executable()));
+                TRY(region_object.add("stack"sv, region.is_stack()));
+                TRY(region_object.add("shared"sv, region.is_shared()));
+                TRY(region_object.add("syscall"sv, region.is_syscall_region()));
+                TRY(region_object.add("purgeable"sv, region.vmobject().is_anonymous()));
+                if (region.vmobject().is_anonymous()) {
+                    TRY(region_object.add("volatile"sv, static_cast<Memory::AnonymousVMObject const&>(region.vmobject()).is_volatile()));
+                }
+                TRY(region_object.add("cacheable"sv, region.is_cacheable()));
+                TRY(region_object.add("address"sv, region.vaddr().get()));
+                TRY(region_object.add("size"sv, region.size()));
+                TRY(region_object.add("amount_resident"sv, region.amount_resident()));
+                TRY(region_object.add("amount_dirty"sv, region.amount_dirty()));
+                TRY(region_object.add("cow_pages"sv, region.cow_pages()));
+                TRY(region_object.add("name"sv, region.name()));
+                TRY(region_object.add("vmobject"sv, region.vmobject().class_name()));
+
+                StringBuilder pagemap_builder;
+                for (size_t i = 0; i < region.page_count(); ++i) {
+                    auto page = region.physical_page(i);
+                    if (!page)
+                        pagemap_builder.append('N');
+                    else if (page->is_shared_zero_page() || page->is_lazy_committed_page())
+                        pagemap_builder.append('Z');
+                    else
+                        pagemap_builder.append('P');
+                }
+                TRY(region_object.add("pagemap"sv, pagemap_builder.string_view()));
+                TRY(region_object.finish());
             }
-            TRY(region_object.add("pagemap"sv, pagemap_builder.string_view()));
-            TRY(region_object.finish());
-        }
-        return {};
+            return {};
+        });
     }));
     TRY(array.finish());
     return {};
-- 
cgit v1.2.3