From 04ba31b8c5ec71bf57cc34d58f8dd1d08bea87ab Mon Sep 17 00:00:00 2001 From: Liav A Date: Sat, 11 Sep 2021 15:57:41 +0300 Subject: Kernel+Userland: Remove loadable kernel moduless These interfaces are broken for about 9 months, maybe longer than that. At this point, this is just a dead code nobody tests or tries to use, so let's remove it instead of keeping a stale code just for the sake of keeping it and hoping someone will fix it. To better justify this, I read that OpenBSD removed loadable kernel modules in 5.7 release (2014), mainly for the same reason we do - nobody used it so they had no good reason to maintain it. Still, OpenBSD had LKMs being effectively working, which is not the current state in our project for a long time. An arguably better approach to minimize the Kernel image size is to allow dropping drivers and features while compiling a new image. --- Kernel/Process.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'Kernel/Process.cpp') diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 62014dfcc9..1b53fc2e7d 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -25,7 +25,6 @@ #include #include #include -#include #include #include #include @@ -45,7 +44,6 @@ static void create_signal_trampoline(); RecursiveSpinlock g_profiling_lock; static Atomic next_pid; static Singleton> s_processes; -READONLY_AFTER_INIT HashMap>* g_modules; READONLY_AFTER_INIT Memory::Region* g_signal_trampoline_region; static Singleton> s_hostname; @@ -72,8 +70,6 @@ ProcessID Process::allocate_pid() UNMAP_AFTER_INIT void Process::initialize() { - g_modules = new HashMap>; - next_pid.store(0, AK::MemoryOrder::memory_order_release); // Note: This is called before scheduling is initialized, and before APs are booted. -- cgit v1.2.3