From 340b524c0d2e0db15eca9dd7d69ab3b1788b11c8 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 17 Oct 2019 20:46:04 +0200 Subject: Kernel: Minor cleanup in TCPSocket::send_tcp_packet() --- Kernel/Net/TCPSocket.cpp | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'Kernel/Net') diff --git a/Kernel/Net/TCPSocket.cpp b/Kernel/Net/TCPSocket.cpp index b82ab43389..8389cec31c 100644 --- a/Kernel/Net/TCPSocket.cpp +++ b/Kernel/Net/TCPSocket.cpp @@ -162,19 +162,20 @@ void TCPSocket::send_tcp_packet(u16 flags, const void* payload, int payload_size tcp_packet.set_checksum(compute_tcp_checksum(local_address(), peer_address(), tcp_packet, payload_size)); if (tcp_packet.has_syn() || payload_size > 0) { - m_not_acked.append({ m_sequence_number, buffer, 0, {} }); + m_not_acked.append({ m_sequence_number, move(buffer), 0, {} }); send_outgoing_packets(); - } else { - auto routing_decision = route_to(peer_address(), local_address()); - ASSERT(!routing_decision.is_zero()); + return; + } - routing_decision.adapter->send_ipv4( - routing_decision.next_hop, peer_address(), IPv4Protocol::TCP, - buffer.data(), buffer.size(), ttl()); + auto routing_decision = route_to(peer_address(), local_address()); + ASSERT(!routing_decision.is_zero()); - m_packets_out++; - m_bytes_out += buffer.size(); - } + routing_decision.adapter->send_ipv4( + routing_decision.next_hop, peer_address(), IPv4Protocol::TCP, + buffer.data(), buffer.size(), ttl()); + + m_packets_out++; + m_bytes_out += buffer.size(); } void TCPSocket::send_outgoing_packets() -- cgit v1.2.3