From ed46d52252375be732841d980f9eec02ea7691f5 Mon Sep 17 00:00:00 2001
From: Hendiadyoin1 <leon2002.la@gmail.com>
Date: Sat, 17 Jul 2021 18:29:28 +0200
Subject: Everywhere: Use AK/Math.h if applicable

AK's version should see better inlining behaviors, than the LibM one.
We avoid mixed usage for now though.

Also clean up some stale math includes and improper floatingpoint usage.
---
 AK/Complex.h | 44 ++++++++------------------------------------
 1 file changed, 8 insertions(+), 36 deletions(-)

(limited to 'AK/Complex.h')

diff --git a/AK/Complex.h b/AK/Complex.h
index aaefaf2e90..b9deb170f9 100644
--- a/AK/Complex.h
+++ b/AK/Complex.h
@@ -7,10 +7,7 @@
 #pragma once
 
 #include <AK/Concepts.h>
-#if __has_include(<math.h>)
-#    define AKCOMPLEX_CAN_USE_MATH_H
-#    include <math.h>
-#endif
+#include <AK/Math.h>
 
 #ifdef __cplusplus
 #    if __cplusplus >= 201103L
@@ -45,18 +42,9 @@ public:
 
     constexpr T magnitude_squared() const COMPLEX_NOEXCEPT { return m_real * m_real + m_imag * m_imag; }
 
-#    ifdef AKCOMPLEX_CAN_USE_MATH_H
     constexpr T magnitude() const COMPLEX_NOEXCEPT
     {
-        // for numbers 32 or under bit long we don't need the extra precision of sqrt
-        // although it may return values with a considerable error if real and imag are too big?
-        if constexpr (sizeof(T) <= sizeof(float)) {
-            return sqrtf(m_real * m_real + m_imag * m_imag);
-        } else if constexpr (sizeof(T) <= sizeof(double)) {
-            return sqrt(m_real * m_real + m_imag * m_imag);
-        } else {
-            return sqrtl(m_real * m_real + m_imag * m_imag);
-        }
+        return hypot(m_real, m_imag);
     }
 
     constexpr T phase() const COMPLEX_NOEXCEPT
@@ -67,15 +55,8 @@ public:
     template<AK::Concepts::Arithmetic U, AK::Concepts::Arithmetic V>
     static constexpr Complex<T> from_polar(U magnitude, V phase)
     {
-        if constexpr (sizeof(T) <= sizeof(float)) {
-            return Complex<T>(magnitude * cosf(phase), magnitude * sinf(phase));
-        } else if constexpr (sizeof(T) <= sizeof(double)) {
-            return Complex<T>(magnitude * cos(phase), magnitude * sin(phase));
-        } else {
-            return Complex<T>(magnitude * cosl(phase), magnitude * sinl(phase));
-        }
+        return Complex<T>(magnitude * cos(phase), magnitude * sin(phase));
     }
-#    endif
 
     template<AK::Concepts::Arithmetic U>
     constexpr Complex<T>& operator=(const Complex<U>& other)
@@ -288,7 +269,6 @@ static constinit Complex<T> complex_real_unit = Complex<T>((T)1, (T)0);
 template<AK::Concepts::Arithmetic T>
 static constinit Complex<T> complex_imag_unit = Complex<T>((T)0, (T)1);
 
-#    ifdef AKCOMPLEX_CAN_USE_MATH_H
 template<AK::Concepts::Arithmetic T, AK::Concepts::Arithmetic U>
 static constexpr bool approx_eq(const Complex<T>& a, const Complex<U>& b, const double margin = 0.000001)
 {
@@ -300,23 +280,15 @@ static constexpr bool approx_eq(const Complex<T>& a, const Complex<U>& b, const
 template<AK::Concepts::Arithmetic T>
 static constexpr Complex<T> cexp(const Complex<T>& a)
 {
-    // FIXME: this can probably be faster and not use so many expensive trigonometric functions
-    if constexpr (sizeof(T) <= sizeof(float)) {
-        return expf(a.real()) * Complex<T>(cosf(a.imag()), sinf(a.imag()));
-    } else if constexpr (sizeof(T) <= sizeof(double)) {
-        return exp(a.real()) * Complex<T>(cos(a.imag()), sin(a.imag()));
-    } else {
-        return expl(a.real()) * Complex<T>(cosl(a.imag()), sinl(a.imag()));
-    }
+    // FIXME: this can probably be faster and not use so many "expensive" trigonometric functions
+    return exp(a.real()) * Complex<T>(cos(a.imag()), sin(a.imag()));
 }
 }
-#    endif
 
+using AK::approx_eq;
+using AK::cexp;
 using AK::Complex;
 using AK::complex_imag_unit;
 using AK::complex_real_unit;
-#    ifdef AKCOMPLEX_CAN_USE_MATH_H
-using AK::approx_eq;
-using AK::cexp;
-#    endif
+
 #endif
-- 
cgit v1.2.3