From 8a3e6225382f90b633dd4079b16c66d4d98f5646 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 21 May 2021 15:21:51 +0200 Subject: Browser: Stop leaking popup windows We were leaking the "view source" and "downloading file" windows for some reason, presumably it was necessary when these were first added. Since they are owned by the spawning browser window, there's no need to leak them. --- Userland/Applications/Browser/Tab.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/Userland/Applications/Browser/Tab.cpp b/Userland/Applications/Browser/Tab.cpp index e7e05682e5..7573132c40 100644 --- a/Userland/Applications/Browser/Tab.cpp +++ b/Userland/Applications/Browser/Tab.cpp @@ -61,7 +61,6 @@ void Tab::start_download(const URL& url) window->set_resizable(false); window->set_main_widget(url); window->show(); - [[maybe_unused]] auto& unused = window.leak_ref(); } void Tab::view_source(const URL& url, const String& source) @@ -76,7 +75,6 @@ void Tab::view_source(const URL& url, const String& source) window->set_title(url.to_string()); window->set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/filetype-text.png")); window->show(); - [[maybe_unused]] auto& unused = window.leak_ref(); } Tab::Tab(BrowserWindow& window, Type type) -- cgit v1.2.3