From 43456ad708838b4702b023d5a3d2d3acaf3f221b Mon Sep 17 00:00:00 2001 From: Jamie Mansfield Date: Sat, 19 Nov 2022 12:05:29 +0000 Subject: LibJS: Add spec comments to TypedArray.prototype.reduceRight --- .../LibJS/Runtime/TypedArrayPrototype.cpp | 26 +++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp b/Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp index 0915c4cbb5..d8badaa92c 100644 --- a/Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp @@ -865,30 +865,54 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::reduce) // 23.2.3.24 %TypedArray%.prototype.reduceRight ( callbackfn [ , initialValue ] ), https://tc39.es/ecma262/#sec-%typedarray%.prototype.reduce JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::reduce_right) { + // 1. Let O be the this value. + // 2. Perform ? ValidateTypedArray(O). auto* typed_array = TRY(validate_typed_array_from_this(vm)); + // 3. Let len be O.[[ArrayLength]]. auto length = typed_array->array_length(); + // 4. If IsCallable(callbackfn) is false, throw a TypeError exception. auto* callback_function = TRY(callback_from_args(vm, vm.names.reduce.as_string())); + // 5. If len is 0 and initialValue is not present, throw a TypeError exception. if (length == 0 && vm.argument_count() <= 1) return vm.throw_completion(ErrorType::ReduceNoInitial); + // 6. Let k be len - 1. i32 k = (i32)length - 1; + + // 7. Let accumulator be undefined. Value accumulator; + + // 8. If initialValue is present, then if (vm.argument_count() > 1) { + // a. Set accumulator to initialValue. accumulator = vm.argument(1); - } else { + } + // 9. Else, + else { + // a. Let Pk be ! ToString(𝔽(k)). + // b. Set accumulator to ! Get(O, Pk). accumulator = MUST(typed_array->get(k)); + + // c. Set k to k - 1. --k; } + // 10. Repeat, while k ≥ 0, for (; k >= 0; --k) { + // a. Let Pk be ! ToString(𝔽(k)). + // b. Let kValue be ! Get(O, Pk). auto k_value = MUST(typed_array->get(k)); + // c. Set accumulator to ? Call(callbackfn, undefined, « accumulator, kValue, 𝔽(k), O »). accumulator = TRY(call(vm, *callback_function, js_undefined(), accumulator, k_value, Value(k), typed_array)); + + // d. Set k to k - 1. } + // 11. Return accumulator. return accumulator; } -- cgit v1.2.3