From 4277e2d58f1fc3f3600d36bf1cc71027374b8cf4 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 27 Nov 2022 20:13:15 +0100 Subject: Kernel: Add some spec links and comments to sys$posix_fallocate() --- Kernel/Syscalls/fallocate.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Kernel/Syscalls/fallocate.cpp b/Kernel/Syscalls/fallocate.cpp index 18269c061d..8f924219ed 100644 --- a/Kernel/Syscalls/fallocate.cpp +++ b/Kernel/Syscalls/fallocate.cpp @@ -12,11 +12,13 @@ namespace Kernel { +// https://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.html ErrorOr Process::sys$posix_fallocate(int fd, Userspace userspace_offset, Userspace userspace_length) { VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); + // [EINVAL] The len argument is less than zero, or the offset argument is less than zero, or the underlying file system does not support this operation. auto offset = TRY(copy_typed_from_user(userspace_offset)); if (offset < 0) return EINVAL; @@ -31,9 +33,12 @@ ErrorOr Process::sys$posix_fallocate(int fd, Userspace us return EFBIG; auto description = TRY(open_file_description(fd)); + + // [EBADF] The fd argument references a file that was opened without write permission. if (!description->is_writable()) return EBADF; + // [ESPIPE] The fd argument is associated with a pipe or FIFO. if (description->is_fifo()) return ESPIPE; -- cgit v1.2.3