From 6503b4b3c131d8cd691128b43f049c2c5f949fc4 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 3 Feb 2021 18:42:02 +0100 Subject: Revert "Meta: Enable CodeQL static analysis for Serenity" This reverts commit f0bf723424069a03a5b5f9264e2a88e35cab568d. CodeQL never finds anything and regularly crashes, failing the build. --- .github/codeql/config.yml | 8 -------- .github/workflows/cmake.yml | 11 ----------- 2 files changed, 19 deletions(-) delete mode 100644 .github/codeql/config.yml (limited to '.github') diff --git a/.github/codeql/config.yml b/.github/codeql/config.yml deleted file mode 100644 index 71742d9a41..0000000000 --- a/.github/codeql/config.yml +++ /dev/null @@ -1,8 +0,0 @@ -name: "SerenityOS CodeQL Config" - -queries: - - uses: security-and-quality - - uses: security-extended - -# Documentation for configuring CodeQL is located here: -# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 5cdf4afbea..ef01991cc3 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -83,7 +83,6 @@ jobs: key: ${{ runner.os }}-toolchain-i686-${{ hashFiles('Userland/Libraries/LibC/**/*.h', 'Toolchain/Patches/*.patch', 'Toolchain/BuildIt.sh') }} - name: Restore or regenerate Toolchain run: TRY_USE_LOCAL_TOOLCHAIN=y ${{ github.workspace }}/Toolchain/BuildIt.sh - # TODO: ccache # https://cristianadam.eu/20200113/speeding-up-c-plus-plus-github-actions-using-ccache/ # https://github.com/cristianadam/HelloWorld/blob/master/.github/workflows/build_cmake.yml @@ -98,12 +97,6 @@ jobs: # === ACTUALLY BUILD AND TEST === - - name: Initialize CodeQL Static Analysis for C++ - uses: github/codeql-action/init@v1 - with: - languages: cpp - config-file: ./.github/codeql/config.yml - - name: Build Serenity and Tests working-directory: ${{ github.workspace }}/Build run: cmake --build . @@ -121,10 +114,6 @@ jobs: working-directory: ${{ github.workspace }}/Build/Meta/Lagom run: ./test-compress - # Run analysis last, so contributors get lint/test feedback ASAP. - - name: Perform post build CodeQL Analysis - uses: github/codeql-action/analyze@v1 - # === NOTIFICATIONS === - name: Dump event info -- cgit v1.2.3