Age | Commit message (Collapse) | Author |
|
|
|
Fixes desync between file and title.
|
|
And replace DeprecatedString and fix misnamed argument in show_error()
|
|
Instead of crashing on failed icon loading with TRY(), let's report
missing but non-critical resources in detail and gracefully move on.
|
|
Pithier and it matches the naming convention used in FontEditor's
child widgets. Since it was never used outside MainWidget and there
will soon be no guarantee that m_font is nonnull, the public
BitmapFont& getter has also been removed.
|
|
This workaround has not been needed since 5c92397
|
|
As these were only used internally, let's simplify things and prevent
potential desync between widget state and saved settings by moving the
logic into their respective actions.
|
|
Since moving initialization out of the constructor and recalculating
GlyphMap's content size on range and font changes, these deferrals are
no longer needed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
And propagate errors while building them.
|
|
This will let us neatly ensure capacities, do unchecked appends, and
iterate by size() on FontEditor's models.
|
|
|
|
Fixes seek actions not activating by keyboard shortcut when
GlyphMapWidget has focus.
|
|
automatic_content_width() should return grid container width that is
supposed to be set by determine_intrinsic_size_of_grid_container().
|
|
When a width/height constraint is applied to GFC it should set its own
width/height to the sum of track sizes according to the spec.
Changes in layout tests are improvement over what we had before.
|
|
This solves the issue when track with "fixed" min sizing function were
treated like "auto" during sizing.
|
|
When the host clears the clipboard (e.g. by running `pbcopy </dev/null`)
the Spice server sends an empty string to us. Previously, we would crash
as `AnonymousBuffer::create_with_size` doesn't accept a size of 0. Fix
this by passing `{}` to `async_set_clipboard_data` in this case.
|
|
|
|
We achieve this by adding a new Layout::ImageProvider class and having
both HTMLImageElement and HTMLObjectElement inherit from it.
The HTML spec is vague on how object image loading should work, which
is why this first pass is focusing on image elements.
|
|
This first pass is enough to get us:
- Image loading via fetch
- Source selection via srcset and sizes attributes
|
|
Also comes with a little extra CSS parser helper for parsing "sizes"
attributes in images.
|
|
|
|
This patch adds HTML::ImageRequest and HTML::DecodedImageData.
The latter had to use a different name than "ImageData", as there is
already an IDL-exposed ImageData class in HTML.
|
|
Found while playing Fixme-Roulette.
|
|
It looks like this migration it taking a while, so let's make sure noone
accidentally introduces new usages of this currently-unused API.
|
|
|
|
This makes hovering around on GitHub fast again, as it no longer
believes that the grid-template-areas property keeps changing
when it didn't :^)
Also made to_string() work for calc() values as well, since I stumbled
upon that while debugging this.
|
|
|
|
This change brings more spec compliant implementation of functions to
calculate min/max contributions of grid items in containing block size.
|
|
Note that previously, the only check was that at least one byte was read
from /dev/devctl. This is incorrect, as potentially not the entire
struct was read. In practice, this probably never happened, but the new
code at least detects this case and aborts.
|
|
This results in a new OOM prevention. Hooray!
|
|
Advances #17129.
|
|
|
|
This prevents callers from accidentally discarding the result of
initialize(), which was the root cause of this OSS Fuzz bug:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55896&q=label%3AProj-serenity&sort=summary
|
|
|
|
Note that this unfortunately requires the same workaround as <link>
elements to handle CORS cross-origin responses.
|
|
The UTF-8 decoder will currently crash if it is provided invalid UTF-8
input. Instead, change its behavior to match that of all other decoders
to replace invalid code points with U+FFFD. This is required by the web.
|
|
This will make it more convenient in places where the Variant would need
to be re-typed outside of this class.
|
|
The completion callback currently only accepts a JavaScriptModuleScript.
The same callback will need to be used for ClassicScript scripts as well
so allow the callback to accept any Script type. The single existing
outside caller already stores the result as a Script.
|
|
|
|
|
|
|
|
|
|
If this value somehow becomes nan/inf the painter will keep splitting
the path till the process OOMs, a simple crash would be preferable.
|
|
If just .to_px() is used the height can end up as the float `inf` or
`nan`. This caused an OOM when loading Polygon as this `inf` would
become a `nan` and propagate to the SVG painting, which then attempts
to draw a path with nan control points, which would make the
Gfx::Painter infinitely split the path till it OOM'd.
|