| Age | Commit message (Collapse) | Author |
|---|
|
This allows us to use TRY in these functions :^).
|
|
This also allows us to create TypedArrays with an existing buffer thus
clearing up an additional FIXME in TextEncoder.
|
|
This removes a number of vm.exception() checks which are now caught
directly by TRY. Make use of these checks in
{Global, Eval}DeclarationInstantiation and while we're here add spec
comments.
|
|
|
|
This was already handled in the CSS machinery, we just never parsed it.
|
|
This is basically the same as `auto` in the spec, so let's just treat
them as identical for now. Gets rid of some Discord CSS parser
spam. :^)
|
|
During the LengthPercentage split, I converted the individual-corner
`border-foo-bar-radius` properties to LengthPercentage but forgot
`border-radius` itself! Oops. Discord's CSS was doing `border-radius:
50%` a lot, so this cuts down on CSS parser spam.
|
|
There's a possible window where the notifications are disabled, and any
request coming at that time will never get any data if it relies on
socket notifications.
|
|
|
|
|
|
Thanks to David for noticing this! :^)
|
|
|
|
In C++, this is a raw pointer to a Script::HostDefined.
|
|
In C++, this is an OwnPtr<Realm::HostDefined>.
|
|
|
|
Now that the GML formatter is both perserving comments and also mostly
agrees to the existing GML style, it can be used to auto-format all the
GML files in the system. This commit does not only contain the scripts
for running the formatting on CI and the pre-commit hook, but also
initially formats all the existing GML files so that the hook is
successfull.
|
|
As we no longer remove comments when formatting GML, this gets rid of
the warning presented to the user when there are comments in the GML.
|
|
This commit introduces a couple of connected changes that are hard to
untangle, unfortunately:
- Parse GML into the AST instead of JSON
- Change the load_from_json API on Widget to load_from_gml_ast
- Remove this same API from Core::Object as it isn't used outside of
LibGUI and was a workaround for the object registration detection;
by verifying the objects we're getting and casting we can remove this
constraint.
- Format GML by calling the formating APIs on the AST itself; remove
GMLFormatter.cpp as it's not needed anymore.
After this change, GML formatting already respects comments :^)
|
|
This Abstract Syntax Tree is specifically designed to represent GML and
also includes comments. It will be used in the next commit to replace
JSON in the GML system.
|
|
This was causing some macro redefinition errors after the headers ended
up in the same file through some includes. The simple fix is to undefine
the macro after use.
|
|
Prefixes are very much a C thing which we don't need in C++. This commit
moves all GML-related classes in LibGUI into the GUI::GML namespace, a
change somewhat overdue.
|
|
|
|
|
|
|
|
And fix Line Highlighting's duplicate alt-menu shortcut.
Previously only text on the cursor's line was highlighted. This makes
discerning cursor focus on empty lines easier.
|
|
And simplify its construction.
The first visual line was being over-clipped vertically by an amount
equal to the frame's thickness. Selections and icons in TextBoxes and
the first line of Editors now display correctly.
|
|
|
|
|
|
|
|
|
|
|
|
All other browser already support this feature.
There is a Stage 1 proposal to standardize this, but it does not seem
to be active.
|
|
This matches the variable name used in the spec.
|
|
Interpreter::run() *does* now return a Completion. :^)
|
|
This will be used by the new EventTarget to check if it needs to do
special error event handling. Currently it isn't used for anything
else.
|
|
This fix this test262 test:
built-ins/JSON/stringify/value-string-escape-unicode.js
|
|
|
|
Per the CSSOM View spec, these are aliases for clientX and clientY.
|
|
Add or insert some missing browser icons.
|
|
We were chopping the top row of pixels off of the website favicons in
Browser's location editor. :^)
|
|
Previously it was hard to enter a url with a port in browser:
"example.com:8080" -> Protocol not implemented: example.com
This patch makes an attempt at parsing the input as an url with http
first an validates if the url has a port.
"example.com:8080" -> "http://example.com:8080"
|
|
Add 16x16 and 32x32 icons for GML files.
|
|
The current implementation of step 2a sort of manually implemented GetV
with a ToObject + Get combo. But in the call to Get, the receiver wasn't
the correct object. So when invoking toJSON, the receiver was an Object
type rather than a BigInt.
This also adds spec comments to SerializeJSONProperty.
|
|
Some over-eager copy-pasting led to incorrect code for the new chain.
|
|
Let's just use reference-counting pointers for this, even if it seems
safe not to.
|
|
This function was unnecessarily nested, which created a scenario where
we could get stuck in an infinite loop without advancing the
current_object pointer up the browsing context container chain.
|
|
Thanks to U9G for catching this! :^)
|
|
|
|
PropertyKey used to be called PropertyName, but got renamed. Let's
update all the variables of this type as well.
|
|
If the mousedown event hits something with is_focusable()==true,
we now update the document's focused element *instead* of placing the
text cursor at the focusable element.
This allows you to begin editing input elements by clicking them.
This feels very hackish and we'll need to come up with something nicer.
|
