Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-12-15 | LibJS: Convert ordinary_create_from_constructor() to NonnullGCPtr | Linus Groh | |
2022-12-15 | LibJS: Convert Heap::allocate{,_without_realm}() to NonnullGCPtr | Linus Groh | |
2022-12-15 | LibJS: Ensure Optional<Completion>'s defaults to empty completion | Linus Groh | |
Default-constructing the m_value Completion made it have an undefined JS value when not overridden in a constructor, such as the conditional initialization in Optional(Optional<JS::Completion> const&). See investigation by Tim here: https://github.com/SerenityOS/serenity/pull/16498#discussion_r1049090456 Co-authored-by: Timothy Flynn <trflynn89@pm.me> | |||
2022-12-15 | LibJS: Throw a RangeError when when formatting strings in DurationFormat | Timothy Flynn | |
This is a normative change in the Intl.DurationFormat proposal. See: https://github.com/tc39/proposal-intl-duration-format/commit/2546080 | |||
2022-12-15 | LibJS: Access DurationRecord properties in alphabetical order | Timothy Flynn | |
This is a normative change in the Intl.DurationFormat proposal. See: https://github.com/tc39/proposal-intl-duration-format/commit/42e99b8 | |||
2022-12-15 | LibJS: Move IsValidDurationRecord check to ToDurationRecord | Timothy Flynn | |
This is an editorial change in the Intl.DurationFormat proposal. See: https://github.com/tc39/proposal-intl-duration-format/commit/fb21723 | |||
2022-12-15 | LibJS: Remove infallibility markers from some Intl.DurationFormat AOs | Timothy Flynn | |
This is an editorial change in the Intl.DurationFormat proposal. See: https://github.com/tc39/proposal-intl-duration-format/commit/fa2b3d0 | |||
2022-12-14 | LibJS: Set DateTimeFormat's time zone when the CLDR download is disabled | Timothy Flynn | |
We return early from the DateTimeFormat constructor to avoid crashing on assertions when the CLDR is disabled. However, after commit 019211b, the spec now mandates we assert the time zone identifier is valid. The early return resulted in this identifier being an empty string. | |||
2022-12-14 | LibJS: Remove Object(Object& prototype) footgun | Andreas Kling | |
This constructor was easily confused with a copy constructor, and it was possible to accidentally copy-construct Objects in at least one way that we dicovered (via generic ThrowCompletionOr construction). This patch adds a mandatory ConstructWithPrototypeTag parameter to the constructor to disambiguate it. | |||
2022-12-14 | LibJS: Don't "copy construct" temporary value in ThrowCompletionOr ctor | Andreas Kling | |
It was possible for the generic ThrowCompletionOr constructor to "copy-construct" a JS Object when instantiating a ThrowCompletionOr via e.g `return *object;`. This happened because it chose the Object(Object& prototype) constructor which will be removed in a subsequent commit. It was not easy to debug. As a first step towards avoiding this in the future, the generic ThrowCompletionOr constructor now takes the value as a const reference. | |||
2022-12-14 | LibJS: Convert WrappedFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert WeakSet::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert WeakRef::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert WeakMap::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert TypedArray::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert SymbolObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert StringObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert StringIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert SetIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Set::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert RegExpStringIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert RegExpObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Realm::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert ProxyObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert PromiseResolvingFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert PromiseFooElementFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert PromiseReaction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Promise::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Object::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert NumberObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert NativeFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert MapIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Map::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intrinsics::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::Segments::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::SegmentIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::NumberFormatFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::Locale::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::DateTimeFormatFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Intl::CollatorCompareFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert GeneratorObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Error::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert ECMAScriptFunctionObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert Date::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert DataView::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert BoundFunction::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert BooleanObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert BigIntObject::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert AsyncFromSyncIterator::create() to NonnullGCPtr | Linus Groh | |
2022-12-14 | LibJS: Convert ArrayIterator::create() to NonnullGCPtr | Linus Groh | |