serenity - The Serenity Operating System 🐞

Age	Commit message (Collapse)	Author
2023-01-28	AK: Remove `try_` prefix from FixedArray creation functions	Linus Groh

2023-01-03	LibCompress: Switch `ZlibCompressor` to a constructor pattern	Tim Schumacher
	We don't have anything fallible in the constructor yet, but what's there should be fallible and once we switch to Core::Stream it will be fallible.
2022-12-09	Everywhere: Use C++ concepts instead of requires clauses	Moustafa Raafat

2022-12-08	LibGfx: Use a FixedArray for the dummy scanline in PNGWriter	Andreas Kling
	PNGWriter sets up one dummy scanline with the same width as the other scanlines in order to allow addressing the "previous scanline" without complicating the code. By using a FixedArray instead of a VLA, we sidestep the risk of stack overflow and instead get something that can signal OOM.
2022-12-08	LibGfx: Propagate errors that occur internally in PNGWriter	Andreas Kling
	This patch basically uses the TRY() macro throughout PNGWriter instead of relying on the MUST()'ing wrappers in Vector and ByteBuffer. One FIXME was killed in the making of this patch. :^)
2022-12-08	LibGfx+Userland: Make PNGWriter::encode() return ErrorOr<ByteBuffer>	Andreas Kling
	This is a first step towards handling PNG encoding failures instead of just falling over and crashing the program. This initial step will cause encode() to return an error if the final ByteBuffer copy fails to allocate. There are more potential failures that will be surfaced by subsequent commits. Two FIXMEs were killed in the making of this patch. :^)
2022-12-06	AK+Everywhere: Rename String to DeprecatedString	Linus Groh
	We have a new, improved string type coming up in AK (OOM aware, no null state), and while it's going to use UTF-8, the name UTF8String is a mouthful - so let's free up the String name by renaming the existing class. Making the old one have an annoying name will hopefully also help with quick adoption :^)
2022-07-30	LibGfx: Compress PNGs with a better compression level	Karol Kosek
	While for a general purpose encoder a good balance between compression speed and size by default is important, in case of PNG it don't matter that much, as it was said in #14594. Also note that it's not the best we can have. We use zlib's compression level, which has a range of 0-4, while our deflate implementation ranges from 0 to 5.
2022-07-10	LibGfx: Default-initialize dummy scanline	Karol Kosek
	This should make the CI happier now.
2022-07-10	LibGfx: Implement PNG filtering on write	Karol Kosek
	Is it another great upgrade to our PNG encoder like in 9aafaec259? Well, not really - it's not a 2x or 55x improvement like you saw there, but still it saves something: - a screenshot of a blank Serenity desktop dropped from about 45 KiB to 40 KiB. - re-encoding NASA photo of the Earth to PNG again saves about 25% (16.5 MiB -> 12.3 MiB), compared to not using filters. [1]: https://commons.wikimedia.org/wiki/File:The_Blue_Marble_(remastered).jpg
2022-07-10	LibGfx: Move PNG header and paeth_predictor function to a shared header	Karol Kosek

2022-07-10	LibGfx: Use enum instead of magic numbers for PNG Color and Filter types	Karol Kosek

2022-06-30	LibGfx: Use ZlibCompressor for compressing PNG files	Karol Kosek
	Previously we were hand-writing all the Zlib and raw Deflated data structures here, but now PNGs will be compressed using ZlibCompressor which will actually try to compress something! :^) Note that we don't do any filtering that should help compress data even more, but even now the results are pretty good: - screenshots of my Serenity desktop are take now about 55 KiB, where previously it was 3 MiB. - re-encoding NASA photo of the Earth[1] to PNG shows a 2x improvement (34.3 MiB -> 16.5 MiB). [1]: https://commons.wikimedia.org/wiki/File:The_Blue_Marble_(remastered).jpg
2022-01-24	Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr	Sam Atkins
	Apologies for the enormous commit, but I don't see a way to split this up nicely. In the vast majority of cases it's a simple change. A few extra places can use TRY instead of manual error checking though. :^)
2022-01-13	LibGfx: Change return type of Adler32 checksums in PNGWriter	Marcus Nilsson
	The two Adler32 checksums are u16 and these two getters were mistakenly left as u32 when PNGChunk::add_as_big_endian() was templated leading to corrupted IDAT fields in our PNGs.
2021-09-06	Everywhere: Make ByteBuffer::{create_*,copy}() OOM-safe	Ali Mohammad Pur

2021-09-06	Everywhere: Use OOM-safe ByteBuffer APIs where possible	Ali Mohammad Pur
	If we can easily communicate failure, let's avoid asserting and report failure instead.
2021-08-01	LibGfx: Fix writing PNG headers on x86_64	Gunnar Beutner
	m_data.size() returns a size_t which is a 64-bit type on x86_64. This resulted in us incorrectly using zero in the PNG header.
2021-08-01	LibGfx: Fix a spelling mistake in a variable name	Gunnar Beutner

2021-07-14	LibGfx: Use clear_with capacity instead of clear in PNGWriter	Aziz Berkay Yesilyurt
	Same vector was cleared up and filled in continuously.
2021-07-14	LibGfx: Store the size of the chunk from start in PNGWriter	Aziz Berkay Yesilyurt
	Before this change PNGWriter::add_chunk used to make a copy of PNGChunk's ByteBuffer to prepend the size of the data. With this change, 4-byte space is saved from the beginning and written at the end of the operation. Avoiding this copy yields significant speed up.
2021-07-14	LibGfx: Prevent a copy in PNGWriter by storing type data at start	Aziz Berkay Yesilyurt

2021-07-14	LibGfx: Prevent frequent memory allocations in PNGWriter	Aziz Berkay Yesilyurt

2021-07-14	LibGfx: Use ByteBuffer instead of Vector<u8> in PNGWriter	Aziz Berkay Yesilyurt
	This is the first step towards reducing the number of copies in PNGWriter by switching to ByteBuffer as underlying storage.
2021-06-12	AK: Rename Vector::append(Vector) => Vector::extend(Vector)	Andreas Kling
	Let's make it a bit more clear when we're appending the elements from one vector to the end of another vector.
2021-04-22	Everything: Move to SPDX license identifiers in all files.	Brian Gianforcaro
	SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-19	LibGfx: Improve PNG encoder API somewhat	Andreas Kling
	This is still far from ideal, but let's at least make it take a Gfx::Bitmap const&.
2021-01-22	LibGfx: adding a very simple PNG writer	Pierre
	With this patch it is possible to create PNG files. Only minimal options are supported. The PNG is created with one big IDAT chunk containing only non-compressible DEFLATE blocks.