| Age | Commit message (Collapse) | Author |
|---|
|
|
|
And clean up Save and Open action code style.
|
|
And update GlyphEditorWidget on initialize(). Fixes Editor not showing
the new active glyph when loading recent fonts from a menu.
|
|
|
|
Feels a bit more natural, at least to align with muscle memory from
other browsers.
|
|
This includes actions such as controlling play state, downloading the
video, and opening the video in a new tab.
|
|
GCC 13 produces the following true positive warnings:
- `-Wredundant-move` when trying to move `result->tooltip()`, which
is a const reference in `Assistant/main.cpp`
- `-Wuse-after-free` when freeing an environment variable before
removing it from `s_malloced_environment_variables`
- `-Wdangling-pointer` when storing an AST node's `this` pointer to the
interpreter's node stack in LibJS. This is not actually an issue, as
it is popped when the scope ends, but GCC has no way of telling this.
|
|
CSVImportDialogPage takes and holds a StringView meaning that the data
was dropped instantly and displayed garbage instead.
|
|
|
|
|
|
|
|
|
|
|
|
The signature of Core::ProcessStatisticsReader::get_all changed, and
instead of requiring a pointer to an open file, it now needs a bool to
indicate whether usernames should be polled or not. `m_proc_all` was
always converted to `false` in `RefPtr::operator bool()`, so we were
missing usernames for a long time.
|
|
|
|
This change allows us to not run the app with elevated privileges.
It uses the Escalator to call a helper and passes the settings as
JsonObject to it.
|
|
- Escalator now uses `posix_spawn` instead of `exec`
- Escalator is now able to forward stdin and stdout
- A few general changes to improve code quality
|
|
Since LibFSAC requires a reified window before loading a font, it
makes sense to have a safe null state for the app.
This lets us stay alive after a failed file request on startup,
handle failure at any point during initialization, and claw back
memory from all our font RefPtrs.
A default startup font or none at all can now be set in FontEditor.ini
|
|
And remove public reference getters as there is no guarantee they are
nonnull.
|
|
FontEditor will need to clear references to its mutable font in
the future while CharacterMap has no use for the highlights clone,
so let's convert GlyphMapWidget's set_font wrapper into a separate
initialize function for the editor and stop hiding the base function
for others. Setting font null in either ultimately points the map to
the system's default font.
|
|
|
|
Fixes desync between file and title.
|
|
And replace DeprecatedString and fix misnamed argument in show_error()
|
|
Instead of crashing on failed icon loading with TRY(), let's report
missing but non-critical resources in detail and gracefully move on.
|
|
Pithier and it matches the naming convention used in FontEditor's
child widgets. Since it was never used outside MainWidget and there
will soon be no guarantee that m_font is nonnull, the public
BitmapFont& getter has also been removed.
|
|
This workaround has not been needed since 5c92397
|
|
As these were only used internally, let's simplify things and prevent
potential desync between widget state and saved settings by moving the
logic into their respective actions.
|
|
Since moving initialization out of the constructor and recalculating
GlyphMap's content size on range and font changes, these deferrals are
no longer needed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
And propagate errors while building them.
|
|
|
|
When either king is in check, its square is now highlighted with a red
background. This behavior can be toggled in GameSettings.
|
|
|
|
This concerns both `BufferedSeekable` and `BufferedFile`.
|
|
While the binary is still called "Browser" for now, let's make it clear
that we're converging on a single name for this application.
|
|
Up until 3d53dc82283e7eccf7a27918dbbcd391dc4988f7, to_string(ColorRole)
returned char*, which prevented us from directly creating a String
class.
|
|
This makes this input consistent with the hardness properties of other
tools.
|
|
It currently supports only headers and code blocks.
|
|
The pattern to construct `Application` was to use the `try_create`
method from the `C_OBJECT` macro. While being safe from an OOM
perspective, this method doesn't propagate errors from the constructor.
This patch make `Application` use the `C_OBJECT_ABSTRACT` and manually
define a `create` method that can bubble up errors from the
construction stage.
This commit also removes the ability to use `argc` and `argv` to
create an `Application`, only `Main`'s `Arguments` can be used.
From a user point of view, the patch renames `try_create` => `create`,
hence the huge number of modified files.
|
|
|
|
This makes the lasso tool behavior consistent with other selection
tools.
|
|
This matches the behavior of other selection tools.
|
|
|
|
The font isn't set in the constructor, there may be a case where the
font hasn't loaded before the first paint event. Therefore, we should
not paint if the font is null. All other methods should be fine.
|
|
The graphics directory is a more suitable home for game assets.
|
