serenity - The Serenity Operating System 🐞

Age	Commit message (Collapse)	Author
2021-01-06	LibWeb: Don't prune whitespace nodes from layout tree	Andreas Kling
	Various whitespace-related issues have been fixed, and support for the different CSS white-space values is improved enough that I think we can stop doing the hack where we just prune whitespace nodes from the tree and actually let them show up. This is a nice step forward for correctness with the slight downside of cluttering up layout tree dumps with tons of whitespace text nodes. But hey, that's the web we know & love. :^) Fixes #4427.
2021-01-06	LibWeb: Rename Layout::Node::style() => computed_values()	Andreas Kling

2021-01-06	LibWeb: Store the used font in Layout::NodeWithStyle	Andreas Kling
	This is a step towards not having to carry the full set of specified values around with every layout node.
2021-01-06	LibWeb: Simplify one kind of whitespace collapsing	Andreas Kling
	For a non-empty TextNode chunk that begins with collapsible whitespace, we can simply step right over the whitespace by adjusting the chunk.
2020-12-18	LibWeb: Only preserve full whitspace for white-space: pre{,-wrap}	Andreas Kling

2020-12-17	LibWeb: Whitespace that causes a line to wrap should be hidden	Andreas Kling
	We were only pruning trailing whitespace on lines. This patch makes it so we also don't add whitespace as the leading line box fragment on new lines. This logic is pretty crufty and I think we can do better, but for now I've just made it handle this extra case so we can stop having lines that start with a space character. :^)
2020-12-15	LibWeb: Put final foreground/background colors in LayoutStyle	Andreas Kling
	This way we don't have to look them up in the CSS::StyleProperties every time we want to paint with them.
2020-12-15	LibWeb: Use IdentifierStyleValue for CSS 'text-transform'	Andreas Kling

2020-12-15	LibWeb: Use IdentifierStyleValue for CSS 'text-decoration-line'	Andreas Kling
	Also 'text-decoration' is actually a shorthand, so treat it that way.
2020-12-10	LibWeb: Use the surrounding text color as the caret color	Andreas Kling
	This way you can always see the cursor as long (as you can see the text you are editing.)
2020-12-06	LibWeb: Pass current target box to BFC::run()	Andreas Kling
	The BFC "context box" is now the outer box of the block formatting context. Previously the context box was always the current target box, which made it hard to reason about who was really the containing block of whom in various places. Note that IFC still has the containing block as its context box, this change only affects BFC. However, to clarify the situation in IFC, I've added a containing_block() getter than returns the context_box().
2020-12-05	LibWeb: Fix off-by-one when computing available space between floats	Andreas Kling
	Whoops, this explains why things were not lining up correctly. :^)
2020-12-05	LibWeb: First slightly naive implementation of CSS floats :^)	Andreas Kling
	Boxes can now be floated left or right, which makes text within the same block formatting context flow around them. We were creating way too many block formatting contexts. As it turns out, we don't need one for every new block, but rather there's a set of rules that determines whether a given block creates a new block formatting context. Each BFC keeps track of the floating boxes within it, and IFC's can then query it to find the available space for line boxes. There's a huge hack in here where we assume all lines are the exact line-height. Making this work with vertically non-uniform lines will require some architectural changes.
2020-12-03	LibWeb: Paint line box fragments during all paint phases	Andreas Kling
	Fragment painting was very limited by only being called during the foreground paint phase. We now paint fragments as part of every phase (and the phase is passed to paint_fragment() of course!)
2020-11-22	LibWeb: Rename LayoutNode classes and move them into Layout namespace	Andreas Kling
	Bring the names of various boxes closer to spec language. This should hopefully make things easier to understand and hack on. :^) Some notable changes: - LayoutNode -> Layout::Node - LayoutBox -> Layout::Box - LayoutBlock -> Layout::BlockBox - LayoutReplaced -> Layout::ReplacedBox - LayoutDocument -> Layout::InitialContainingBlockBox - LayoutText -> Layout::TextNode - LayoutInline -> Layout::InlineNode Note that this is not strictly a "box tree" as we also hang inline/text nodes in the same tree, and they don't generate boxes. (Instead, they contribute line box fragments to their containing block!)