serenity - The Serenity Operating System 🐞

Age	Commit message (Collapse)	Author
2021-12-29	Kernel: Handle promise violations in the syscall handler	Brian Gianforcaro
	Previously we would crash the process immediately when a promise violation was found during a syscall. This is error prone, as we don't unwind the stack. This means that in certain cases we can leak resources, like an OwnPtr / RefPtr tracked on the stack. Or even leak a lock acquired in a ScopeLockLocker. To remedy this situation we move the promise violation handling to the syscall handler, right before we return to user space. This allows the code to follow the normal unwind path, and grantees there is no longer any cleanup that needs to occur. The Process::require_promise() and Process::require_no_promises() functions were modified to return ErrorOr<void> so we enforce that the errors are always propagated by the caller.
2021-12-29	Kernel: Use Process::require_promise() instead of REQUIRE_PROMISE()	Brian Gianforcaro
	This change lays the foundation for making the require_promise return an error hand handling the process abort outside of the syscall implementations, to avoid cases where we would leak resources. It also has the advantage that it makes removes a gs pointer read to look up the current thread, then process for every syscall. We can instead go through the Process this pointer in most cases.
2021-12-29	Kernel: Fix info leak from padding in GenericFramebufferDevice::ioctl	Brian Gianforcaro
	In FB_IOCTL_GET_PROPERTIES we were not initializing the padding of the struct, leading to the potential of an kernel information leak if the caller looked back at it's contents. Lets just be extra paranoid and zero initialize all these structs in we store on the stack while handling ioctls(..).
2021-12-18	Kernel: Use copy_typed_from_user() in more places :^)	Andreas Kling

2021-12-16	Kernel+LibC: Move errno definitions to Kernel/API/POSIX	sin-ack
	This fixes at least half of our LibC includes in the kernel. The source of truth for errno codes and their description strings now lives in Kernel/API/POSIX/errno.h as an enumeration, which LibC includes.
2021-11-21	Everywhere: Fix spelling of "offsetted"	Andreas Kling
	This word is actually pretty awkward in context, but this patch merely fixes the spelling instead of finding a better word.
2021-11-08	Kernel: Replace KResult and KResultOr<T> with Error and ErrorOr<T>	Andreas Kling
	We now use AK::Error and AK::ErrorOr<T> in both kernel and userspace! This was a slightly tedious refactoring that took a long time, so it's not unlikely that some bugs crept in. Nevertheless, it does pass basic functionality testing, and it's just real nice to finally see the same pattern in all contexts. :^)
2021-10-27	Kernel + WindowServer: Re-define the interface to framebuffer devices	Liav A
	We create a base class called GenericFramebufferDevice, which defines all the virtual functions that must be implemented by a FramebufferDevice. Then, we make the VirtIO FramebufferDevice and other FramebufferDevice implementations inherit from it. The most important consequence of rearranging the classes is that we now have one IOCTL method, so all drivers should be committed to not override the IOCTL method or make their own IOCTLs of FramebufferDevice. All graphical IOCTLs are known to all FramebufferDevices, and it's up to the specific implementation whether to support them or discard them (so we require extensive usage of KResult and KResultOr, together with virtual characteristic functions). As a result, the interface is much cleaner and understandable to read.