serenity - The Serenity Operating System 🐞

Age	Commit message (Collapse)	Author
2021-09-21	AK: Introduce ability to default-initialize a Variant	Ben Wiederhake
	I noticed that Variant<Empty, …> is a somewhat common pattern while working on #10080, and this will simplify a few use-cases. :^)
2021-09-16	AK: Use default constructor/destructor instead of declaring an empty one	Brian Gianforcaro
	Default implementations allow for more optimizations. See: https://pvs-studio.com/en/docs/warnings/v832/
2021-09-06	AK: Use the full name of 'integer_sequence_generate_array' in Variant.h	Ali Mohammad Pur
	c27abaabc449e20e8cffac245d1e2686f94e2ba6 moved this out of the global namespace, but did not qualify its users. While this seems to be fine (sometimes, somehow), let's qualify it to avoid random breakage.
2021-08-13	AK+Everywhere: Delete Variant's default constructor	Ali Mohammad Pur
	This was exposed to the user by mistake, and even accumulated a bunch of users that didn't blow up out of sheer luck.
2021-08-12	AK: Don't zero Variant data in the move constructor	Ali Mohammad Pur
	There's no reason to zero the data that will be immediately overwritten.
2021-07-04	AK: Destroy original value when assigning to Variant	Daniel Bertalan

2021-07-04	AK: Use conditionally trivial special member functions	Daniel Bertalan
	This commit makes use of the conditionally trivial special member functions introduced in C++20. Basically, `Optional` and `Variant` inherits whether its wrapped type is trivially copy constructible, trivially copy assignable or trivially destructible. This lets the compiler optimize optimize a large number of their use cases. The constraints have been applied to `Optional`'s converting constructors too in order to make the API more explicit. This feature is not supported by Clang yet, so we use conditional compilation so that Lagom can be built on macOS. Once Clang has P0848R3 support, these can be removed.
2021-06-28	AK: Add and use the RemoveCVReference<T> type trait	Ali Mohammad Pur

2021-06-27	AK: Add explicit Variant conversion operators	Ali Mohammad Pur
	This allows converting between Variants of different types with less pain.
2021-06-26	AK: Undo bogus Variant::downcast() rename	Andreas Kling
	I accidentally renamed these to verify_cast() when doing the global AK::downcast() rename.
2021-06-24	AK: Rename downcast<T> => verify_cast<T>	Andreas Kling
	This makes it much clearer what this cast actually does: it will VERIFY that the thing we're casting is a T (using is<T>()).
2021-06-09	AK: Make a bunch of Variant methods ALWAYS_INLINE	Ali Mohammad Pur

2021-06-02	AK+LibWasm+LibJS: Disallow Variant.has() on types that aren't contained	Ali Mohammad Pur
	Checking for this (and get()'ing it) is always invalid, so let's just disallow it. This also finds two bugs where the code is checking for types that can never actually be in the variant (which was actually a refactor artifact).
2021-05-22	AK: Fix Variant construction from lvalue references	Ali Mohammad Pur
	Fixes #7371 and appends its test cases.
2021-05-22	AK: Remove [[gnu::noinline]] attribute from some variant members	Ali Mohammad Pur
	These were left-overs from a debugging session :P
2021-05-20	Variant: Remove redundant inline keyword	Lenny Maiorani
	Problem: - `constexpr inline` is redundant because `constexpr` implies `inline`. Solution: - Remove redundancy.
2021-05-19	AK: Allow AK::Variant::visit to return a value	Timothy Flynn
	This changes Variant::visit() to forward the value returned by the selected visitor invocation. By perfectly forwarding the returned value, this allows for the visitor to return by value or reference. Note that all provided visitors must return the same type - the compiler will otherwise fail with the message: "inconsistent deduction for auto return type".
2021-05-17	Everywhere: Fix a bunch of typos	Linus Groh

2021-05-13	AK: Fix Variant's copy constructor trying to delegate to the wrong base	Ali Mohammad Pur
	This was forgotten in 4fdbac2.
2021-05-11	AK/Variant: Deduplicate the contained types	Ali Mohammad Pur
	This allows the construction of `Variant<int, int, int>`. While this might not seem useful, it is very useful for making variants that contain a series of member function pointers, which I plan to use in LibGL for glGenLists() and co.
2021-05-11	AK: Avoid the use of typeinfo in Variant	Ali Mohammad Pur
	typeid() and RTTI was a nice clutch to implement this, but let's move away from the horrible slowness and implement variants using type indices for faster variants.
2021-05-05	AK: Add a Variant<Ts...> implementation	Ali Mohammad Pur
	Also adds an AK::Empty struct, because 'empty' variants are useful, but this implementation leaves that to the user (i.e. a variant cannot actually be empty, but it can contain an instance of Empty - i.e. a byte). Note that this is more of a constrained Any type, but they basically do the same things anyway :^)