serenity - The Serenity Operating System 🐞

Age	Commit message (Collapse)	Author
2020-09-14	AK: Lower the requirements for InputStream::eof and rename it.	asynts
	Consider the following snippet: void foo(InputStream& stream) { if(!stream.eof()) { u8 byte; stream >> byte; } } There is a very subtle bug in this snippet, for some input streams eof() might return false even if no more data can be read. In this case an error flag would be set on the stream. Until now I've always ensured that this is not the case, but this made the implementation of eof() unnecessarily complicated. InputFileStream::eof had to keep a ByteBuffer around just to make this possible. That meant a ton of unnecessary copies just to get a reliable eof(). In most cases it isn't actually necessary to have a reliable eof() implementation. In most other cases a reliable eof() is avaliable anyways because in some cases like InputMemoryStream it is very easy to implement.
2020-09-06	Streams: Consistent behaviour when reading from stream with error.	asynts
	The streaming operator doesn't short-circuit, consider the following snippet: void foo(InputStream& stream) { int a, b; stream >> a >> b; } If the first read fails, the second is called regardless. It should be well defined what happens in this case: nothing.
2020-09-01	Streams: Distinguish recoverable and fatal errors.	asynts

2020-08-26	AK: Add CircularDuplexStream class.	asynts