Age | Commit message (Collapse) | Author |
|
Previously, TextEditor processed the Select all command directly on the
keydown event handler. For this reason, WindowManager would not process
it as an action for the focused control and an action with the same
keyboard shortcut from the parent could override the TextEditor's one
even when it is focused.
For instance, when pressing Ctrl+A on the FileManager's path bar, all
files were selected instead, which is not the expected behavior.
Now the Select all command is an actual action on TextEditor, so that
WindowManager can process it correctly before any other actions. I also
added an icon for it!
|
|
If you select some text and drag the cursor outside the widget on the
left hand side, we would previously suddenly snap the selection cursor
to the end of the line instead of keeping it at the start of the line
as you would expect. This patch fixes that. :^)
|
|
If you start selecting text and move the cursor outside the TextEditor
widget area without letting go of the mouse button, we will now keep
scrolling a little bit every 100ms.
|
|
We don't support these yet, and it broke all the tests. :^)
|
|
Suggesting whatever the user has input is not quite sane :^)
|
|
Words are delimited by spaces.
Perhaps this should be a configurable behaviour?
|
|
Prior to this commit, we would treat them the same.
|
|
|
|
|
|
this commit fixes a...surprisingly long-standing ^C bug, where it would
return the buffer instead of voiding it and starting over :^)
|
|
|
|
This commit adds searching in the editor history with ^R.
It does so by instantiating...another Line::Editor inside the current
Line::Editor :^)
|
|
|
|
- Print current source location, if available
- Add a breakpoint at a source location
- "sl" command - step to the next line in source
|
|
DWARF line number information, if generated, is stored in the
.debug_line section of an object file.
The information is encoded as instructions for a VM that is defined in
the DWARF specification.
By executing these instructions, we can extract the encoded line number
information.
|
|
|
|
We allow the ref-counting parts of an object to be mutated even when the
object itself is a const.
An important detail is that we allow invoking 'will_be_destroyed' and
'one_ref_left', which are not required to be const qualified, on const
objects.
|
|
|
|
Instead of scaling on the fly, which is not super aesthetic yet.
|
|
Previously, drag and drop would only work when dragging between node
items on a DirectoryView. This commit makes it possible to drag files to
the empty area of the DirectoryView and copy files more easily between
windows.
|
|
When opening a path, check if it's the current one before pushing it
twice to the path history.
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #1853.
|
|
Fixes #1862.
|
|
These were never meant to stick around.
|
|
|
|
|
|
Fixed a crash occurring when initiating a flood fill out of the bitmap rectangle.
|
|
|
|
We can't assume there's always a parent custody -- when we open "/"
there isn't gonna be one!
Fixes #1858.
|
|
|
|
|
|
|
|
This allows us to run "run-tests -g" for testing with GC after every
heap allocation. This may flush out bugs that would otherwise not
occur if GC'ing only occasionally.
|
|
A MarkedValueList is basically a Vector<JS::Value> that registers with
the Heap and makes sure that the stored values don't get GC'd.
Before this change, we were unsafely keeping Vector<JS::Value> in some
places, which is out-of-reach for the live reference finding logic
since Vector puts its elements on the heap by default.
We now pass all the JavaScript tests even when running with "js -g",
which does a GC on every heap allocation.
|
|
These strings would be applied when inserted into the buffer, but are
not shown as part of the suggestion.
This commit also patches up Userland/js and Shell to use this
functionality
|
|
On the first tab, only complete the token without suggesting extra
stuff, and on further tabs, show suggestions.
Except in one case where the completion is all in the buffer, then
we show the suggestions, but do no completion.
|
|
When copying files, the original file permissions are applied to the
copy. However, this was not done with directories. This should do it.
|
|
|
|
When a drag operation is accepted, we don't check whether the source
nodes contain the destination directory. This could trigger an unwanted
recursive copy.
|
|
This is a bit nicer than getting "Exec format error" after trying to
execvp() a directory.
|
|
If the selection is empty, the model index will be invalid and the file
system model will return the root directory path by default. This causes
the file manager to jump to the root directory when the currently
selected item on the tree view is deselected.
|
|
- Include all options
- Update example REPL session to match current output
- Mention REPL's help()
- Add test mode section
|
|
They now match the new, more verbose error messages.
|
|
This unbreaks the entire test suite. :^)
|
|
Json model wasn't stored after bookmark removal.
Store the model if remove() was successful.
|