| Age | Commit message (Collapse) | Author |
|---|
|
|
|
HTMLSelectElement simply defers to its HTMLOptionsCollection.
|
|
|
|
For example, HTMLOptionsCollection will need to access its root
HTMLSelectElement.
|
|
This is a bit strange in the IDL syntax, but e.g., in HTMLSelectElement,
we have (simplified):
undefined add(optional (HTMLElement or long)? before = null)
This could instead become:
undefined add(optional (HTMLElement or long) before)
This change generates code for the former as if it were the latter.
|
|
|
|
This also acts as a little stress test for flexbox layout :^)
|
|
This prevents accessing the source pixels out of bounds.
|
|
We don't have transform-box yet, so this applies to the border-box
for now.
This also makes us pass a couple Web Platform Tests as well :^)
For example:
https://wpt.live/css/css-transforms/css3-transform-scale-002.html
|
|
This is almost a PositionStyleValue, but it's serialized differently,
so let's use a StyleValueList with 2 length-percentage values.
|
|
This initial (and very basic) implementation of KASLR simply randomizes
the kernel base VA in the 256 MiB range following the default load base.
|
|
|
|
Here goes another Acid3 point :^)
|
|
|
|
Previously, table cells would overlap when they had CSS border or
padding properties defined.
|
|
This scores us another point on Acid3. :^)
|
|
|
|
|
|
There are a few unimplemented features for this type:
1. The value setter should throw a DOMException if it is invoked on an
SVGLength that was declared readonly in another IDL file.
2. SVG::AttributeParser does not parse unit types when it parses lengths
so all SVGLength will have an "unknown" unit for now.
3. Due to (2), methods which convert between units are unimplemented.
|
|
The float type is used quite a bit in the SVG spec.
|
|
The spec text and code didn't match up.
Thanks to Tim for spotting this! :^)
|
|
|
|
Taking care of some old FIXMEs :^)
|
|
Taking care of the FIXMEs I added in earlier patches. :^)
|
|
|
|
With FIXMEs about updating live ranges, but still.
|
|
We were passing the wrong length argument to substring() when
stringifying a range where start and end are the same text node.
Also, make sure we visit all the contained text nodes when appending
them to the output.
This was caught by an Acid3 subtest.
|
|
Another point on Acid3 coming through! :^)
|
|
Note that we don't queue mutation records or update live ranges yet,
I've left those as FIXMEs.
|
|
|
|
|
|
Another point on Acid3. :^)
|
|
This makes stuff like <img width="12.5"> work. This code is not great,
so I've left a FIXME about improving it.
|
|
|
|
|
|
|
|
|
|
We already walk the entire paint tree within each stacking context in
the main hit testing function (StackingContext::hit_test()), so there's
no need for each individual paintable to walk its own children again.
By not doing that, we remove a source of O(n^2) traversal which made hit
testing on deeply nested web pages unbearably slow.
|
|
|
|
This is a convenience accessor to avoid having to say this everywhere:
result.paintable->layout_node().dom_node()
Instead, you can now do:
result.dom_node()
|
|
Using "HitTestResult with null paintable" as a way to signal misses was
unnecessarily confusing. Let's use Optional instead. :^)
|
|
I came across some websites that change an elements CSS "opacity" in
their :hover selectors. That caused us to relayout on hover, which we'd
like to avoid.
With this patch, we now check if a property only affects the stacking
context tree, and if nothing layout-affecting has changed, we only
invalidate the stacking context tree, causing it to be rebuilt on next
paint or hit test.
This makes :hover { opacity: ... } rules much faster. :^)
|
|
There's no actual need to build the stacking context tree before
performing layout. Instead, make it lazy and build the tree when it's
actually needed for something.
This avoids a bunch of work in situations where multiple synchronous
layouts are forced (typically by JavaScript) without painting or hit
testing taking place in between.
It also opens up for style invalidations that only target the stacking
context tree.
|
|
We want to return a view to a constant object, not a constant view,
which we can implicitly copy to get a mutable reference to the object.
Clang-Tidy helpfully pointed this out.
|
|
This should be equivalent, and much shorter than a clamp and static_cast
|
|
This lowers its cognitive complexity from 271 to under 100.
The new `parse_pseudo_simple_selector` still has a complexity of 114.
|
|
... in Parser::parse_simple_selector
|
|
This also removes some else-after-returns and adds some const qualifiers
|
|
|
|
The spec says:
> <delim-token> has a value composed of a single code point.
So using StringView is a bit overkill.
This also allows us to use switch statements in the future.
|
