diff options
Diffstat (limited to 'Libraries/LibGUI')
-rw-r--r-- | Libraries/LibGUI/FilePicker.cpp | 4 | ||||
-rw-r--r-- | Libraries/LibGUI/MessageBox.cpp | 14 | ||||
-rw-r--r-- | Libraries/LibGUI/MessageBox.h | 6 |
3 files changed, 11 insertions, 13 deletions
diff --git a/Libraries/LibGUI/FilePicker.cpp b/Libraries/LibGUI/FilePicker.cpp index 3877df01d8..8cc3f4c0fa 100644 --- a/Libraries/LibGUI/FilePicker.cpp +++ b/Libraries/LibGUI/FilePicker.cpp @@ -160,7 +160,7 @@ FilePicker::FilePicker(Window* parent_window, Mode mode, Options options, const .string(); int rc = mkdir(new_dir_path.characters(), 0777); if (rc < 0) { - MessageBox::show(String::format("mkdir(\"%s\") failed: %s", new_dir_path.characters(), strerror(errno)), "Error", MessageBox::Type::Error, MessageBox::InputType::OK, this); + MessageBox::show(this, String::format("mkdir(\"%s\") failed: %s", new_dir_path.characters(), strerror(errno)), "Error", MessageBox::Type::Error); } else { m_model->update(); } @@ -322,7 +322,7 @@ void FilePicker::on_file_return() LexicalPath path(String::format("%s/%s", m_model->root_path().characters(), m_filename_textbox->text().characters())); if (FilePicker::file_exists(path.string()) && m_mode == Mode::Save) { - auto result = MessageBox::show("File already exists, overwrite?", "Existing File", MessageBox::Type::Warning, MessageBox::InputType::OKCancel); + auto result = MessageBox::show(this, "File already exists, overwrite?", "Existing File", MessageBox::Type::Warning, MessageBox::InputType::OKCancel); if (result == MessageBox::ExecCancel) return; } diff --git a/Libraries/LibGUI/MessageBox.cpp b/Libraries/LibGUI/MessageBox.cpp index df357a02fb..9af920a8c7 100644 --- a/Libraries/LibGUI/MessageBox.cpp +++ b/Libraries/LibGUI/MessageBox.cpp @@ -34,22 +34,20 @@ namespace GUI { -int MessageBox::show(const StringView& text, const StringView& title, Type type, InputType input_type, Window* parent_window) +int MessageBox::show(Window* parent_window, const StringView& text, const StringView& title, Type type, InputType input_type) { - auto box = MessageBox::construct(text, title, type, input_type); - if (parent_window) { - parent_window->add_child(box); + auto box = MessageBox::construct(parent_window, text, title, type, input_type); + if (parent_window) box->set_icon(parent_window->icon()); - } return box->exec(); } -int MessageBox::show_error(const StringView& text, Window* parent_window) +int MessageBox::show_error(Window* parent_window, const StringView& text) { - return show(text, "Error", GUI::MessageBox::Type::Error, GUI::MessageBox::InputType::OK, parent_window); + return show(parent_window, text, "Error", GUI::MessageBox::Type::Error, GUI::MessageBox::InputType::OK); } -MessageBox::MessageBox(const StringView& text, const StringView& title, Type type, InputType input_type, Window* parent_window) +MessageBox::MessageBox(Window* parent_window, const StringView& text, const StringView& title, Type type, InputType input_type) : Dialog(parent_window) , m_text(text) , m_type(type) diff --git a/Libraries/LibGUI/MessageBox.h b/Libraries/LibGUI/MessageBox.h index 243b3469e8..dcd4c64d3c 100644 --- a/Libraries/LibGUI/MessageBox.h +++ b/Libraries/LibGUI/MessageBox.h @@ -50,11 +50,11 @@ public: virtual ~MessageBox() override; - static int show(const StringView& text, const StringView& title, Type type = Type::None, InputType = InputType::OK, Window* parent_window = nullptr); - static int show_error(const StringView& text, Window* parent_window = nullptr); + static int show(Window* parent_window, const StringView& text, const StringView& title, Type type = Type::None, InputType input_type = InputType::OK); + static int show_error(Window* parent_window, const StringView& text); private: - explicit MessageBox(const StringView& text, const StringView& title, Type type = Type::None, InputType = InputType::OK, Window* parent_window = nullptr); + explicit MessageBox(Window* parent_window, const StringView& text, const StringView& title, Type type = Type::None, InputType input_type = InputType::OK); bool should_include_ok_button() const; bool should_include_cancel_button() const; |