summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Kernel/API/POSIX/sys/mman.h4
-rw-r--r--Kernel/Syscalls/mmap.cpp8
2 files changed, 4 insertions, 8 deletions
diff --git a/Kernel/API/POSIX/sys/mman.h b/Kernel/API/POSIX/sys/mman.h
index 65a6618385..bb37c481ac 100644
--- a/Kernel/API/POSIX/sys/mman.h
+++ b/Kernel/API/POSIX/sys/mman.h
@@ -31,8 +31,8 @@ extern "C" {
#define MAP_FAILED ((void*)-1)
-#define MADV_SET_VOLATILE 0x100
-#define MADV_SET_NONVOLATILE 0x200
+#define MADV_SET_VOLATILE 0x1
+#define MADV_SET_NONVOLATILE 0x2
#define MS_SYNC 1
#define MS_ASYNC 2
diff --git a/Kernel/Syscalls/mmap.cpp b/Kernel/Syscalls/mmap.cpp
index 5e358cd171..9660c8b1c2 100644
--- a/Kernel/Syscalls/mmap.cpp
+++ b/Kernel/Syscalls/mmap.cpp
@@ -424,18 +424,14 @@ ErrorOr<FlatPtr> Process::sys$madvise(Userspace<void*> address, size_t size, int
return EINVAL;
if (!region->is_mmap())
return EPERM;
- bool set_volatile = advice & MADV_SET_VOLATILE;
- bool set_nonvolatile = advice & MADV_SET_NONVOLATILE;
- if (set_volatile && set_nonvolatile)
- return EINVAL;
- if (set_volatile || set_nonvolatile) {
+ if (advice == MADV_SET_VOLATILE || advice == MADV_SET_NONVOLATILE) {
if (!region->vmobject().is_anonymous())
return EINVAL;
auto& vmobject = static_cast<Memory::AnonymousVMObject&>(region->vmobject());
if (!vmobject.is_purgeable())
return EINVAL;
bool was_purged = false;
- TRY(vmobject.set_volatile(set_volatile, was_purged));
+ TRY(vmobject.set_volatile(advice == MADV_SET_VOLATILE, was_purged));
return was_purged ? 1 : 0;
}
return EINVAL;