diff options
| -rw-r--r-- | AK/UUID.cpp | 4 | ||||
| -rw-r--r-- | Meta/Lagom/Fuzzers/FuzzHttpRequest.cpp | 2 | ||||
| -rw-r--r-- | Userland/Libraries/LibC/netdb.cpp | 4 | ||||
| -rw-r--r-- | Userland/Libraries/LibCore/MimeData.cpp | 2 | ||||
| -rw-r--r-- | Userland/Libraries/LibTLS/Record.cpp | 1 | ||||
| -rw-r--r-- | Userland/Services/InspectorServer/InspectableProcess.cpp | 2 | ||||
| -rw-r--r-- | Userland/Utilities/js.cpp | 4 |
7 files changed, 12 insertions, 7 deletions
diff --git a/AK/UUID.cpp b/AK/UUID.cpp index 53e14c0a5f..839bffeb0f 100644 --- a/AK/UUID.cpp +++ b/AK/UUID.cpp @@ -28,6 +28,10 @@ void UUID::convert_string_view_to_uuid(const StringView& uuid_string_view) auto fourth_unit = decode_hex(uuid_string_view.substring_view(19, 4)); auto fifth_unit = decode_hex(uuid_string_view.substring_view(24, 12)); + VERIFY(first_unit.value().size() == 4 && second_unit.value().size() == 2 + && third_unit.value().size() == 2 && fourth_unit.value().size() == 2 + && fifth_unit.value().size() == 6); + m_uuid_buffer.span().overwrite(0, first_unit.value().data(), first_unit.value().size()); m_uuid_buffer.span().overwrite(4, second_unit.value().data(), second_unit.value().size()); m_uuid_buffer.span().overwrite(6, third_unit.value().data(), third_unit.value().size()); diff --git a/Meta/Lagom/Fuzzers/FuzzHttpRequest.cpp b/Meta/Lagom/Fuzzers/FuzzHttpRequest.cpp index 3abab3ed26..e0e95fa39e 100644 --- a/Meta/Lagom/Fuzzers/FuzzHttpRequest.cpp +++ b/Meta/Lagom/Fuzzers/FuzzHttpRequest.cpp @@ -14,7 +14,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) if (!request_wrapper.has_value()) return 1; - auto request = request_wrapper.value(); + auto& request = request_wrapper.value(); VERIFY(request.method() != HTTP::HttpRequest::Method::Invalid); return 0; diff --git a/Userland/Libraries/LibC/netdb.cpp b/Userland/Libraries/LibC/netdb.cpp index 0fe5ba2063..77d0b790dd 100644 --- a/Userland/Libraries/LibC/netdb.cpp +++ b/Userland/Libraries/LibC/netdb.cpp @@ -466,7 +466,7 @@ static bool fill_getserv_buffers(const char* line, ssize_t read) } auto alias = split_line[i].to_byte_buffer(); alias.append("\0", sizeof(char)); - __getserv_alias_list_buffer.append(alias); + __getserv_alias_list_buffer.append(move(alias)); } } @@ -636,7 +636,7 @@ static bool fill_getproto_buffers(const char* line, ssize_t read) break; auto alias = split_line[i].to_byte_buffer(); alias.append("\0", sizeof(char)); - __getproto_alias_list_buffer.append(alias); + __getproto_alias_list_buffer.append(move(alias)); } } diff --git a/Userland/Libraries/LibCore/MimeData.cpp b/Userland/Libraries/LibCore/MimeData.cpp index 327a67e4f9..4641e597c5 100644 --- a/Userland/Libraries/LibCore/MimeData.cpp +++ b/Userland/Libraries/LibCore/MimeData.cpp @@ -13,7 +13,7 @@ Vector<String> MimeData::formats() const { Vector<String> mime_types; mime_types.ensure_capacity(m_data.size()); - for (auto it : m_data) + for (auto& it : m_data) mime_types.unchecked_append(it.key); return mime_types; } diff --git a/Userland/Libraries/LibTLS/Record.cpp b/Userland/Libraries/LibTLS/Record.cpp index 3994b70640..0633a573fe 100644 --- a/Userland/Libraries/LibTLS/Record.cpp +++ b/Userland/Libraries/LibTLS/Record.cpp @@ -383,6 +383,7 @@ ssize_t TLSv12::handle_message(ReadonlyBytes buffer) if (m_context.connection_status != ConnectionStatus::KeyExchange) { dbgln("unexpected change cipher message"); auto packet = build_alert(true, (u8)AlertDescription::UnexpectedMessage); + write_packet(packet); payload_res = (i8)Error::UnexpectedMessage; } else { dbgln_if(TLS_DEBUG, "change cipher spec message"); diff --git a/Userland/Services/InspectorServer/InspectableProcess.cpp b/Userland/Services/InspectorServer/InspectableProcess.cpp index 73b20048db..bc165b5f99 100644 --- a/Userland/Services/InspectorServer/InspectableProcess.cpp +++ b/Userland/Services/InspectorServer/InspectableProcess.cpp @@ -22,7 +22,7 @@ InspectableProcess::InspectableProcess(pid_t pid, NonnullRefPtr<Core::LocalSocke { m_socket->set_blocking(true); m_socket->on_ready_to_read = [this] { - auto buffer = m_socket->read(1); + [[maybe_unused]] auto buffer = m_socket->read(1); if (m_socket->eof()) { g_processes.remove(m_pid); return; diff --git a/Userland/Utilities/js.cpp b/Userland/Utilities/js.cpp index 95767482c9..4eb6f555e4 100644 --- a/Userland/Utilities/js.cpp +++ b/Userland/Utilities/js.cpp @@ -423,14 +423,14 @@ static void print(JS::Value value) outln(); } -static bool file_has_shebang(ByteBuffer file_contents) +static bool file_has_shebang(ByteBuffer const& file_contents) { if (file_contents.size() >= 2 && file_contents[0] == '#' && file_contents[1] == '!') return true; return false; } -static StringView strip_shebang(ByteBuffer file_contents) +static StringView strip_shebang(ByteBuffer const& file_contents) { size_t i = 0; for (i = 2; i < file_contents.size(); ++i) { |