summaryrefslogtreecommitdiff
path: root/Userland
diff options
context:
space:
mode:
authorAndreas Kling <kling@serenityos.org>2021-04-18 00:53:37 +0200
committerAndreas Kling <kling@serenityos.org>2021-04-18 10:58:22 +0200
commitf77100d66ba279d33555823fa3ee81f18f81232f (patch)
tree5fd877a0b82609b3bc675fc3841519d5e3ed1480 /Userland
parent679feec1958ddae7c7abbbd080dfd50347dd1383 (diff)
downloadserenity-f77100d66ba279d33555823fa3ee81f18f81232f.zip
Browser: Add status tips to most of the actions
Diffstat (limited to 'Userland')
-rw-r--r--Userland/Applications/Browser/Tab.cpp17
-rw-r--r--Userland/Applications/Browser/WindowActions.cpp5
2 files changed, 18 insertions, 4 deletions
diff --git a/Userland/Applications/Browser/Tab.cpp b/Userland/Applications/Browser/Tab.cpp
index 878bd25b57..49abb8fd74 100644
--- a/Userland/Applications/Browser/Tab.cpp
+++ b/Userland/Applications/Browser/Tab.cpp
@@ -113,12 +113,14 @@ Tab::Tab(Type type)
m_go_back_action = GUI::CommonActions::make_go_back_action([this](auto&) { go_back(); }, this);
m_go_forward_action = GUI::CommonActions::make_go_forward_action([this](auto&) { go_forward(); }, this);
m_go_home_action = GUI::CommonActions::make_go_home_action([this](auto&) { load(g_home_url); }, this);
+ m_go_home_action->set_status_tip("Go to home page");
toolbar.add_action(*m_go_back_action);
toolbar.add_action(*m_go_forward_action);
toolbar.add_action(*m_go_home_action);
m_reload_action = GUI::CommonActions::make_reload_action([this](auto&) { reload(); }, this);
+ m_reload_action->set_status_tip("Reload current page");
toolbar.add_action(*m_reload_action);
@@ -298,11 +300,14 @@ Tab::Tab(Type type)
auto& app_menu = m_menubar->add_menu("&File");
app_menu.add_action(WindowActions::the().create_new_tab_action());
- app_menu.add_action(GUI::Action::create(
+
+ auto close_tab_action = GUI::Action::create(
"&Close Tab", { Mod_Ctrl, Key_W }, Gfx::Bitmap::load_from_file("/res/icons/16x16/close-tab.png"), [this](auto&) {
on_tab_close_request(*this);
},
- this));
+ this);
+ close_tab_action->set_status_tip("Close current tab");
+ app_menu.add_action(close_tab_action);
app_menu.add_separator();
app_menu.add_action(GUI::CommonActions::make_quit_action([](auto&) {
@@ -349,6 +354,7 @@ Tab::Tab(Type type)
}
},
this);
+ view_source_action->set_status_tip("View source code of the current page");
auto inspect_dom_tree_action = GUI::Action::create(
"Inspect &DOM Tree", { Mod_None, Key_F12 }, [this](auto&) {
@@ -369,12 +375,13 @@ Tab::Tab(Type type)
}
},
this);
+ inspect_dom_tree_action->set_status_tip("Open DOM inspector window for this page");
auto& inspect_menu = m_menubar->add_menu("&Inspect");
inspect_menu.add_action(*view_source_action);
inspect_menu.add_action(*inspect_dom_tree_action);
- inspect_menu.add_action(GUI::Action::create(
+ auto js_console_action = GUI::Action::create(
"Open &JS Console", { Mod_Ctrl, Key_I }, [this](auto&) {
if (m_type == Type::InProcessWebView) {
if (!m_console_window) {
@@ -406,7 +413,9 @@ Tab::Tab(Type type)
m_console_window->move_to_front();
}
},
- this));
+ this);
+ js_console_action->set_status_tip("Open JavaScript console for this page");
+ inspect_menu.add_action(js_console_action);
auto& debug_menu = m_menubar->add_menu("&Debug");
debug_menu.add_action(GUI::Action::create(
diff --git a/Userland/Applications/Browser/WindowActions.cpp b/Userland/Applications/Browser/WindowActions.cpp
index 63e965ebb2..0f5db41f00 100644
--- a/Userland/Applications/Browser/WindowActions.cpp
+++ b/Userland/Applications/Browser/WindowActions.cpp
@@ -49,6 +49,7 @@ WindowActions::WindowActions(GUI::Window& window)
on_create_new_tab();
},
&window);
+ m_create_new_tab_action->set_status_tip("Open a new tab");
m_next_tab_action = GUI::Action::create(
"&Next Tab", { Mod_Ctrl, Key_PageDown }, [this](auto&) {
@@ -56,6 +57,7 @@ WindowActions::WindowActions(GUI::Window& window)
on_next_tab();
},
&window);
+ m_next_tab_action->set_status_tip("Switch to the next tab");
m_previous_tab_action = GUI::Action::create(
"&Previous Tab", { Mod_Ctrl, Key_PageUp }, [this](auto&) {
@@ -63,6 +65,7 @@ WindowActions::WindowActions(GUI::Window& window)
on_previous_tab();
},
&window);
+ m_previous_tab_action->set_status_tip("Switch to the previous tab");
m_about_action = GUI::Action::create(
"&About Browser", GUI::Icon::default_icon("app-browser").bitmap_for_size(16), [this](const GUI::Action&) {
@@ -70,6 +73,7 @@ WindowActions::WindowActions(GUI::Window& window)
on_about();
},
&window);
+ m_about_action->set_status_tip("Show application about box");
m_show_bookmarks_bar_action = GUI::Action::create_checkable(
"&Bookmarks Bar", { Mod_Ctrl, Key_B },
@@ -78,6 +82,7 @@ WindowActions::WindowActions(GUI::Window& window)
on_show_bookmarks_bar(action);
},
&window);
+ m_show_bookmarks_bar_action->set_status_tip("Show/hide the bookmarks bar");
}
}