diff options
author | Linus Groh <mail@linusgroh.de> | 2022-12-10 00:04:35 +0000 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2022-12-10 11:23:23 +0000 |
commit | e53c8ae593d5dc95ae7e9684559985ec763bb545 (patch) | |
tree | 9babc0ae5620e82f0b906f8d386a4006cb80c166 /Userland | |
parent | 27ed1f6d5eba6411e5969df8b1719c39f4144c06 (diff) | |
download | serenity-e53c8ae593d5dc95ae7e9684559985ec763bb545.zip |
LibJS: Add spec comments to less_than()
Diffstat (limited to 'Userland')
-rw-r--r-- | Userland/Libraries/LibJS/Runtime/Value.cpp | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/Userland/Libraries/LibJS/Runtime/Value.cpp b/Userland/Libraries/LibJS/Runtime/Value.cpp index c2a4581a6b..50de732bd9 100644 --- a/Userland/Libraries/LibJS/Runtime/Value.cpp +++ b/Userland/Libraries/LibJS/Runtime/Value.cpp @@ -1259,12 +1259,23 @@ ThrowCompletionOr<Value> greater_than_equals(VM& vm, Value lhs, Value rhs) } // 13.10 Relational Operators, https://tc39.es/ecma262/#sec-relational-operators +// RelationalExpression : RelationalExpression < ShiftExpression ThrowCompletionOr<Value> less_than(VM& vm, Value lhs, Value rhs) { + // 1. Let lref be ? Evaluation of RelationalExpression. + // 2. Let lval be ? GetValue(lref). + // 3. Let rref be ? Evaluation of ShiftExpression. + // 4. Let rval be ? GetValue(rref). + // NOTE: This is handled in the AST or Bytecode interpreter. + + // OPTIMIZATION: If both values are i32, we can do a direct comparison without calling into IsLessThan. if (lhs.is_int32() && rhs.is_int32()) return lhs.as_i32() < rhs.as_i32(); - TriState relation = TRY(is_less_than(vm, lhs, rhs, true)); + // 5. Let r be ? IsLessThan(lval, rval, true). + auto relation = TRY(is_less_than(vm, lhs, rhs, true)); + + // 6. If r is undefined, return false. Otherwise, return r. if (relation == TriState::Unknown) return Value(false); return Value(relation == TriState::True); |