diff options
author | Karol Kosek <krkk@serenityos.org> | 2022-06-14 21:57:29 +0200 |
---|---|---|
committer | Sam Atkins <atkinssj@gmail.com> | 2022-06-20 12:55:50 +0100 |
commit | c6eaa39b990e2c654e09cc3bf7605de7ec7c13be (patch) | |
tree | 78b4f75ce8b53d1ad1df0c42b5d1ed29e02f2b0a /Userland | |
parent | 237a5bedd259e606027f36e2b758f4bafde9048b (diff) | |
download | serenity-c6eaa39b990e2c654e09cc3bf7605de7ec7c13be.zip |
LibWeb: Make doubleclicking select the nearest word
Diffstat (limited to 'Userland')
-rw-r--r-- | Userland/Libraries/LibWeb/Page/EventHandler.cpp | 40 |
1 files changed, 39 insertions, 1 deletions
diff --git a/Userland/Libraries/LibWeb/Page/EventHandler.cpp b/Userland/Libraries/LibWeb/Page/EventHandler.cpp index ecdfdd9cf7..e153ecb6fa 100644 --- a/Userland/Libraries/LibWeb/Page/EventHandler.cpp +++ b/Userland/Libraries/LibWeb/Page/EventHandler.cpp @@ -545,7 +545,45 @@ bool EventHandler::handle_doubleclick(Gfx::IntPoint const& position, unsigned bu auto offset = compute_mouse_event_offset(position, *layout_node); node->dispatch_event(UIEvents::MouseEvent::create_from_platform_event(UIEvents::EventNames::dblclick, offset.x(), offset.y(), position.x(), position.y(), button)); - // FIXME: Select word + // NOTE: Dispatching an event may have disturbed the world. + if (!paint_root() || paint_root() != node->document().paint_box()) + return true; + + if (button == GUI::MouseButton::Primary) { + if (auto result = paint_root()->hit_test(position.to_type<float>(), Painting::HitTestType::TextCursor); result.has_value()) { + auto paintable = result->paintable; + if (!paintable->dom_node()) + return true; + + auto const& layout_node = paintable->layout_node(); + if (!layout_node.is_text_node()) + return true; + auto const& text_for_rendering = verify_cast<Layout::TextNode>(layout_node).text_for_rendering(); + + int first_word_break_before = [&] { + // Start from one before the index position to prevent selecting only spaces between words, caused by the addition below. + // This also helps us dealing with cases where index is equal to the string length. + for (int i = result->index_in_node - 1; i >= 0; --i) { + if (is_ascii_space(text_for_rendering[i])) { + // Don't include the space in the selection + return i + 1; + } + } + return 0; + }(); + + int first_word_break_after = [&] { + for (size_t i = result->index_in_node; i < text_for_rendering.length(); ++i) { + if (is_ascii_space(text_for_rendering[i])) + return i; + } + return text_for_rendering.length(); + }(); + + m_browsing_context.set_cursor_position(DOM::Position(*paintable->dom_node(), first_word_break_after)); + layout_root()->set_selection({ { paintable->layout_node(), first_word_break_before }, { paintable->layout_node(), first_word_break_after } }); + } + } return true; } |