AK: Explicitly calculate length of char* when printing

This moves out the calculation of the char* out to the formatter.
Additionally, we now print (null) when a null pointer is passed.

1 files changed, 5 insertions, 1 deletions

diff --git a/Userland/Libraries/LibCore/ArgsParser.cpp b/Userland/Libraries/LibCore/ArgsParser.cpp
index 021e83924f..ead8ed0925 100644
--- a/Userland/Libraries/LibCore/ArgsParser.cpp
+++ b/Userland/Libraries/LibCore/ArgsParser.cpp
@@ -275,8 +275,12 @@ void ArgsParser::print_usage_markdown(FILE* file, char const* argv0)
     for (auto& opt : m_options) {
         if (opt.hide_mode != OptionHideMode::None)
             continue;
+
+        // FIXME: We allow opt.value_name to be empty even if the option
+        //        requires an argument. This should be disallowed as it will
+        //        currently display a blank name after the option.
         if (opt.requires_argument)
-            out(file, " [{} {}]", opt.name_for_display(), opt.value_name);
+            out(file, " [{} {}]", opt.name_for_display(), opt.value_name ?: "");
         else
             out(file, " [{}]", opt.name_for_display());
     }