summaryrefslogtreecommitdiff
path: root/Userland/top.cpp
diff options
context:
space:
mode:
authorAndreas Kling <awesomekling@gmail.com>2019-12-30 18:46:17 +0100
committerAndreas Kling <awesomekling@gmail.com>2019-12-30 18:46:17 +0100
commit50677bf806e73d6b2bf940e0192f170b7bbaf3e4 (patch)
treeded0adfb9b7ef673c85847ea0636e091101b31c0 /Userland/top.cpp
parent816d3e6208bb4d24267d3c87833e550054a5248b (diff)
downloadserenity-50677bf806e73d6b2bf940e0192f170b7bbaf3e4.zip
Kernel: Refactor scheduler to use dynamic thread priorities
Threads now have numeric priorities with a base priority in the 1-99 range. Whenever a runnable thread is *not* scheduled, its effective priority is incremented by 1. This is tracked in Thread::m_extra_priority. The effective priority of a thread is m_priority + m_extra_priority. When a runnable thread *is* scheduled, its m_extra_priority is reset to zero and the effective priority returns to base. This means that lower-priority threads will always eventually get scheduled to run, once its effective priority becomes high enough to exceed the base priority of threads "above" it. The previous values for ThreadPriority (Low, Normal and High) are now replaced as follows: Low -> 10 Normal -> 30 High -> 50 In other words, it will take 20 ticks for a "Low" priority thread to get to "Normal" effective priority, and another 20 to reach "High". This is not perfect, and I've used some quite naive data structures, but I think the mechanism will allow us to build various new and interesting optimizations, and we can figure out better data structures later on. :^)
Diffstat (limited to 'Userland/top.cpp')
-rw-r--r--Userland/top.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/Userland/top.cpp b/Userland/top.cpp
index d892130b4b..842abb5733 100644
--- a/Userland/top.cpp
+++ b/Userland/top.cpp
@@ -37,7 +37,7 @@ struct ThreadData {
unsigned cpu_percent { 0 };
unsigned cpu_percent_decimal { 0 };
- String priority;
+ u32 priority;
String username;
String state;
};
@@ -146,10 +146,10 @@ int main(int, char**)
});
for (auto* thread : threads) {
- printf("%6d %3d %c %-8s %-10s %6zu %6zu %2u.%1u %s\n",
+ printf("%6d %3d %2u %-8s %-10s %6zu %6zu %2u.%1u %s\n",
thread->pid,
thread->tid,
- thread->priority[0],
+ thread->priority,
thread->username.characters(),
thread->state.characters(),
thread->amount_virtual / 1024,