diff options
| author | Linus Groh <mail@linusgroh.de> | 2022-08-20 08:25:24 +0100 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2022-08-23 13:58:30 +0100 |
| commit | f9705eb2f489416a32d145f5363ab0783949add3 (patch) | |
| tree | f83770b5209855f6aea045bf29e1b5ab657d5a21 /Userland/Utilities | |
| parent | 999da617c5a59f2c8bc8b199c69014ee04668ee1 (diff) | |
| download | serenity-f9705eb2f489416a32d145f5363ab0783949add3.zip | |
LibJS: Replace GlobalObject with VM in Intl AOs [Part 1/19]
Instead of passing a GlobalObject everywhere, we will simply pass a VM,
from which we can get everything we need: common names, the current
realm, symbols, arguments, the heap, and a few other things.
In some places we already don't actually need a global object and just
do it for consistency - no more `auto& vm = global_object.vm();`!
This will eventually automatically fix the "wrong realm" issue we have
in some places where we (incorrectly) use the global object from the
allocating object, e.g. in call() / construct() implementations. When
only ever a VM is passed around, this issue can't happen :^)
I've decided to split this change into a series of patches that should
keep each commit down do a somewhat manageable size.
Diffstat (limited to 'Userland/Utilities')
| -rw-r--r-- | Userland/Utilities/js.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Userland/Utilities/js.cpp b/Userland/Utilities/js.cpp index 9be0d945cf..92646c125c 100644 --- a/Userland/Utilities/js.cpp +++ b/Userland/Utilities/js.cpp @@ -753,7 +753,7 @@ static void print_intl_number_format(JS::Intl::NumberFormat const& number_format print_value(JS::Value(number_format.max_significant_digits()), seen_objects); } js_out("\n useGrouping: "); - print_value(number_format.use_grouping_to_value(number_format.global_object()), seen_objects); + print_value(number_format.use_grouping_to_value(number_format.vm()), seen_objects); js_out("\n roundingType: "); print_value(js_string(number_format.vm(), number_format.rounding_type_string()), seen_objects); js_out("\n roundingMode: "); @@ -798,7 +798,7 @@ static void print_intl_date_time_format(JS::Intl::DateTimeFormat& date_time_form print_value(js_string(date_time_format.vm(), date_time_format.time_style_string()), seen_objects); } - JS::Intl::for_each_calendar_field(date_time_format.global_object(), date_time_format, [&](auto& option, auto const& property, auto const&) -> JS::ThrowCompletionOr<void> { + JS::Intl::for_each_calendar_field(date_time_format.vm(), date_time_format, [&](auto& option, auto const& property, auto const&) -> JS::ThrowCompletionOr<void> { using ValueType = typename RemoveReference<decltype(option)>::ValueType; if (!option.has_value()) |