LibCore+Everywhere: Remove ArgsParser::add*(char const*&)

This is not guaranteed to always work correctly as ArgsParser deals in
StringViews and might have a non-properly-null-terminated string as a
value. As a bonus, using StringView (and DeprecatedString where
necessary) leads to nicer looking code too :^)

1 files changed, 2 insertions, 2 deletions

diff --git a/Userland/Utilities/useradd.cpp b/Userland/Utilities/useradd.cpp
index 0bef6ae42b..1eb2fe26ac 100644
--- a/Userland/Utilities/useradd.cpp
+++ b/Userland/Utilities/useradd.cpp
@@ -31,7 +31,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
 {
     TRY(Core::System::pledge("stdio wpath rpath cpath chown"));
 
-    char const* home_path = nullptr;
+    StringView home_path;
     int uid = 0;
     int gid = USERS_GID;
     bool create_home_dir = false;
@@ -108,7 +108,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
     }
 
     DeprecatedString home;
-    if (!home_path)
+    if (home_path.is_empty())
         home = DeprecatedString::formatted("/home/{}", username);
     else
         home = home_path;