diff options
| author | Timothy Flynn <trflynn89@pm.me> | 2023-03-13 17:30:51 -0400 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2023-03-13 22:05:22 +0000 |
| commit | 97536e468498b91ffa1252e964cbf1ce08eb5944 (patch) | |
| tree | 94e350290f158042a428494e92dfc1490a216c9a /Userland/Utilities/headless-browser.cpp | |
| parent | b4d3fea0024001f899ace5e6f377d7232df21656 (diff) | |
| download | serenity-97536e468498b91ffa1252e964cbf1ce08eb5944.zip | |
LibWeb+Ladybird+Userland: Port window.[alert,confirm,prompt] to String
LibGUI and WebDriver (read: JSON) API boundaries use DeprecatedString,
so that is as far as these changes can reach.
The one change which isn't just a DeprecatedString to String replacement
is handling the "null" prompt response. We previously checked for the
null DeprecatedString, whereas we now represent this as an empty
Optional<String>.
Diffstat (limited to 'Userland/Utilities/headless-browser.cpp')
| -rw-r--r-- | Userland/Utilities/headless-browser.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Userland/Utilities/headless-browser.cpp b/Userland/Utilities/headless-browser.cpp index 0eb070c1fb..498a23104f 100644 --- a/Userland/Utilities/headless-browser.cpp +++ b/Userland/Utilities/headless-browser.cpp @@ -114,10 +114,10 @@ private: void notify_server_did_request_context_menu(Badge<WebView::WebContentClient>, Gfx::IntPoint) override { } void notify_server_did_request_link_context_menu(Badge<WebView::WebContentClient>, Gfx::IntPoint, const URL&, DeprecatedString const&, unsigned) override { } void notify_server_did_request_image_context_menu(Badge<WebView::WebContentClient>, Gfx::IntPoint, const URL&, DeprecatedString const&, unsigned, Gfx::ShareableBitmap const&) override { } - void notify_server_did_request_alert(Badge<WebView::WebContentClient>, DeprecatedString const&) override { } - void notify_server_did_request_confirm(Badge<WebView::WebContentClient>, DeprecatedString const&) override { } - void notify_server_did_request_prompt(Badge<WebView::WebContentClient>, DeprecatedString const&, DeprecatedString const&) override { } - void notify_server_did_request_set_prompt_text(Badge<WebView::WebContentClient>, DeprecatedString const&) override { } + void notify_server_did_request_alert(Badge<WebView::WebContentClient>, String const&) override { } + void notify_server_did_request_confirm(Badge<WebView::WebContentClient>, String const&) override { } + void notify_server_did_request_prompt(Badge<WebView::WebContentClient>, String const&, String const&) override { } + void notify_server_did_request_set_prompt_text(Badge<WebView::WebContentClient>, String const&) override { } void notify_server_did_request_accept_dialog(Badge<WebView::WebContentClient>) override { } void notify_server_did_request_dismiss_dialog(Badge<WebView::WebContentClient>) override { } void notify_server_did_get_source(const URL&, DeprecatedString const&) override { } |