Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr

Apologies for the enormous commit, but I don't see a way to split this
up nicely. In the vast majority of cases it's a simple change. A few
extra places can use TRY instead of manual error checking though. :^)

1 files changed, 2 insertions, 2 deletions

diff --git a/Userland/Utilities/disk_benchmark.cpp b/Userland/Utilities/disk_benchmark.cpp
index d55c5073c4..551be5a491 100644
--- a/Userland/Utilities/disk_benchmark.cpp
+++ b/Userland/Utilities/disk_benchmark.cpp
@@ -96,7 +96,7 @@ int main(int argc, char** argv)
                 continue;
 
             auto buffer_result = ByteBuffer::create_uninitialized(block_size);
-            if (!buffer_result.has_value()) {
+            if (buffer_result.is_error()) {
                 warnln("Not enough memory to allocate space for block size = {}", block_size);
                 continue;
             }
@@ -107,7 +107,7 @@ int main(int argc, char** argv)
             while (timer.elapsed() < time_per_benchmark * 1000) {
                 out(".");
                 fflush(stdout);
-                auto result = benchmark(filename, file_size, block_size, *buffer_result, allow_cache);
+                auto result = benchmark(filename, file_size, block_size, buffer_result.value(), allow_cache);
                 if (!result.has_value())
                     return 1;
                 results.append(result.release_value());