Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.

1 files changed, 5 insertions, 5 deletions

diff --git a/Userland/Tests/LibC/accuracy-strtod.cpp b/Userland/Tests/LibC/accuracy-strtod.cpp
index 32b1875f6f..6cd210d9d9 100644
--- a/Userland/Tests/LibC/accuracy-strtod.cpp
+++ b/Userland/Tests/LibC/accuracy-strtod.cpp
@@ -263,11 +263,11 @@ static long long cast_ll(double d)
         long long as_ll;
     };
     typedef char assert_double_8bytes[sizeof(double) == 8 ? 1 : -1];
-    (void)sizeof(assert_double_8bytes);
+    [[maybe_unused]] auto double_size = sizeof(assert_double_8bytes);
     typedef char assert_ll_8bytes[sizeof(long long) == 8 ? 1 : -1];
-    (void)sizeof(assert_ll_8bytes);
+    [[maybe_unused]] auto longlong_size = sizeof(assert_ll_8bytes);
     typedef char assert_readable_8bytes[sizeof(readable_t) == 8 ? 1 : -1];
-    (void)sizeof(assert_readable_8bytes);
+    [[maybe_unused]] auto readable8_size = sizeof(assert_readable_8bytes);
     readable_t readable;
     readable.as_double = d;
     return readable.as_ll;
@@ -280,9 +280,9 @@ static bool is_strtod_close(strtod_fn_t strtod_fn, const char* test_string, cons
         unsigned char as_bytes[8];
     };
     typedef char assert_double_8bytes[sizeof(double) == 8 ? 1 : -1];
-    (void)sizeof(assert_double_8bytes);
+    [[maybe_unused]] auto double_size = sizeof(assert_double_8bytes);
     typedef char assert_readable_8bytes[sizeof(readable_t) == 8 ? 1 : -1];
-    (void)sizeof(assert_readable_8bytes);
+    [[maybe_unused]] auto readable8_size = sizeof(assert_readable_8bytes);
     readable_t readable;
     char* endptr = (char*)0x123;