summaryrefslogtreecommitdiff
path: root/Userland/Shell/Builtin.cpp
diff options
context:
space:
mode:
authorsin-ack <sin-ack@users.noreply.github.com>2022-07-11 20:10:18 +0000
committerAndreas Kling <kling@serenityos.org>2022-07-12 23:11:35 +0200
commitc8585b77d263d15807231cb8bd1345d2591b9495 (patch)
treeac3c44a6f7d6fad59b942809d67b92826386b25c /Userland/Shell/Builtin.cpp
parent3f3f45580ab7266258e97cb3cecf1e24716d61c5 (diff)
downloadserenity-c8585b77d263d15807231cb8bd1345d2591b9495.zip
Everywhere: Replace single-char StringView op. arguments with chars
This prevents us from needing a sv suffix, and potentially reduces the need to run generic code for a single character (as contains, starts_with, ends_with etc. for a char will be just a length and equality check). No functional changes.
Diffstat (limited to 'Userland/Shell/Builtin.cpp')
-rw-r--r--Userland/Shell/Builtin.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/Userland/Shell/Builtin.cpp b/Userland/Shell/Builtin.cpp
index 7402220c06..7c8bfa9d97 100644
--- a/Userland/Shell/Builtin.cpp
+++ b/Userland/Shell/Builtin.cpp
@@ -207,11 +207,11 @@ int Shell::builtin_type(int argc, char const** argv)
if (!dont_show_function_source) {
StringBuilder builder;
builder.append(fn.name);
- builder.append("(");
+ builder.append('(');
for (size_t i = 0; i < fn.arguments.size(); i++) {
builder.append(fn.arguments[i]);
if (!(i == fn.arguments.size() - 1))
- builder.append(" ");
+ builder.append(' ');
}
builder.append(") {\n"sv);
if (fn.body) {
@@ -448,7 +448,7 @@ int Shell::builtin_export(int argc, char const** argv)
if (value) {
auto values = value->resolve_as_list(*this);
StringBuilder builder;
- builder.join(" ", values);
+ builder.join(' ', values);
parts.append(builder.to_string());
} else {
// Ignore the export.