summaryrefslogtreecommitdiff
path: root/Userland/Services
diff options
context:
space:
mode:
authorJan de Visser <jan@de-visser.net>2022-01-12 09:49:43 -0500
committerAndreas Kling <kling@serenityos.org>2022-01-16 11:17:15 +0100
commit7fc901d1b39567124a847a12eb431e39be9f15b4 (patch)
treedb84ad8adacf1ad49a0cda37fbe5367dd1dd1bd5 /Userland/Services
parent53cd87cc1dd86aa6ecce6debe18f5607211af39e (diff)
downloadserenity-7fc901d1b39567124a847a12eb431e39be9f15b4.zip
LibSQL+SQLServer: Implement first cut of SELECT ... ORDER BY foo
Ordering is done by replacing the straight Vector holding the query result in the SQLResult object with a dedicated Vector subclass that inserts result rows according to their sort key using a binary search. This is done in the ResultSet class. There are limitations: - "SELECT ... ORDER BY 1" (or 2 or 3 etc) is supposed to sort by the n-th result column. This doesn't work yet - "SELECT ... column-expression alias ... ORDER BY alias" is supposed to sort by the column with the given alias. This doesn't work yet What does work however is something like ```SELECT foo FROM bar SORT BY quux``` i.e. sorted by a column not in the result set. Once functions are supported it should be possible to sort by random functions.
Diffstat (limited to 'Userland/Services')
-rw-r--r--Userland/Services/SQLServer/SQLStatement.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/Userland/Services/SQLServer/SQLStatement.cpp b/Userland/Services/SQLServer/SQLStatement.cpp
index 5c62b7a9a7..c556757318 100644
--- a/Userland/Services/SQLServer/SQLStatement.cpp
+++ b/Userland/Services/SQLServer/SQLStatement.cpp
@@ -104,7 +104,7 @@ void SQLStatement::next()
return;
}
if (m_index < m_result->results().size()) {
- auto& tuple = m_result->results()[m_index++];
+ auto& tuple = m_result->results()[m_index++].row;
client_connection->async_next_result(statement_id(), tuple.to_string_vector());
deferred_invoke([this]() {
next();