summaryrefslogtreecommitdiff
path: root/Userland/Services/WindowServer/ClientConnection.cpp
diff options
context:
space:
mode:
authorBen Wiederhake <BenWiederhake.GitHub@gmx.de>2021-09-07 22:27:18 +0200
committerAndreas Kling <kling@serenityos.org>2021-09-08 10:53:49 +0200
commitc6e56612f560340a1eda66acc6974a2eb447bc46 (patch)
treef38a366b1bf06e5b8bc19f665b52d3997e39fa6c /Userland/Services/WindowServer/ClientConnection.cpp
parent0a69da08aa4cbbd21203bcce0f33a322cb94b7ad (diff)
downloadserenity-c6e56612f560340a1eda66acc6974a2eb447bc46.zip
LibGUI+WindowServer: Remove now-obsolete cursor tracking feature
This feature was problematic for several reasons: - Tracking *all* the user activity seems like a privacy nightmare. - LibGUI actually only supports one globally tracking widget per window, even if no window is necessary, or if multiple callbacks are desired. - Widgets can easily get confused whether an event is actually directed at it, or is actually just the result of global tracking. The third item caused an issue where right-clicking CatDog opened two context menus instead of one.
Diffstat (limited to 'Userland/Services/WindowServer/ClientConnection.cpp')
-rw-r--r--Userland/Services/WindowServer/ClientConnection.cpp10
1 files changed, 0 insertions, 10 deletions
diff --git a/Userland/Services/WindowServer/ClientConnection.cpp b/Userland/Services/WindowServer/ClientConnection.cpp
index b6466ccaeb..907cbe6c9a 100644
--- a/Userland/Services/WindowServer/ClientConnection.cpp
+++ b/Userland/Services/WindowServer/ClientConnection.cpp
@@ -653,16 +653,6 @@ void ClientConnection::set_window_backing_store(i32 window_id, [[maybe_unused]]
window.invalidate(false);
}
-void ClientConnection::set_global_cursor_tracking(i32 window_id, bool enabled)
-{
- auto it = m_windows.find(window_id);
- if (it == m_windows.end()) {
- did_misbehave("SetGlobalCursorTracking: Bad window ID");
- return;
- }
- it->value->set_global_cursor_tracking_enabled(enabled);
-}
-
void ClientConnection::set_global_mouse_tracking(bool enabled)
{
m_does_global_mouse_tracking = enabled;