diff options
| author | MacDue <macdue@dueutil.tech> | 2022-12-18 22:49:09 +0000 |
|---|---|---|
| committer | Tim Flynn <trflynn89@pm.me> | 2022-12-19 11:37:56 -0500 |
| commit | 3de5dcf383be73ac4a69615318013b2ec863b2f1 (patch) | |
| tree | b169bdfdf68742a7360e5a90964fd4dcd4ee34aa /Userland/Services/WebContent | |
| parent | e3ad5731f7cb3c295e6b6fee644fe92f5a0ad613 (diff) | |
| download | serenity-3de5dcf383be73ac4a69615318013b2ec863b2f1.zip | |
Browser+WebContent: Fixup some DOM inspector weirdness
This fixes a few things I noticed whilst working on the inspector
for Ladybird.
1.
The computed and resolved values were being passed swapped around
from the inspect_dom_node() IPC call. I.e. computed values were
passed as resolved values and vice versa. This was then fixed by
swapping them again in the InspectorWidget (two errors canceled out).
2.
Resolved values were called "specified values" seemingly only in the
inspect_dom_node() IPC calls. This was a little confusing so I've
renamed them to back to "resolved values" for consistency.
3.
The inspector took and stored the DOM JSON strings unnecessarily,
all the models immediately parse the JSON and don't need the strings
to hang around.
Diffstat (limited to 'Userland/Services/WebContent')
| -rw-r--r-- | Userland/Services/WebContent/WebContentClient.ipc | 2 | ||||
| -rw-r--r-- | Userland/Services/WebContent/WebContentServer.ipc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Userland/Services/WebContent/WebContentClient.ipc b/Userland/Services/WebContent/WebContentClient.ipc index 455377b83c..6d57963904 100644 --- a/Userland/Services/WebContent/WebContentClient.ipc +++ b/Userland/Services/WebContent/WebContentClient.ipc @@ -37,7 +37,7 @@ endpoint WebContentClient did_request_dismiss_dialog() =| did_get_source(URL url, DeprecatedString source) =| did_get_dom_tree(DeprecatedString dom_tree) =| - did_get_dom_node_properties(i32 node_id, DeprecatedString specified_style, DeprecatedString computed_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing_json) =| + did_get_dom_node_properties(i32 node_id, DeprecatedString computed_style, DeprecatedString resolved_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing_json) =| did_change_favicon(Gfx::ShareableBitmap favicon) =| did_request_all_cookies(URL url) => (Vector<Web::Cookie::Cookie> cookies) did_request_named_cookie(URL url, DeprecatedString name) => (Optional<Web::Cookie::Cookie> cookie) diff --git a/Userland/Services/WebContent/WebContentServer.ipc b/Userland/Services/WebContent/WebContentServer.ipc index 91b5e29af4..55f5a43a1c 100644 --- a/Userland/Services/WebContent/WebContentServer.ipc +++ b/Userland/Services/WebContent/WebContentServer.ipc @@ -36,7 +36,7 @@ endpoint WebContentServer debug_request(DeprecatedString request, DeprecatedString argument) =| get_source() =| inspect_dom_tree() =| - inspect_dom_node(i32 node_id, Optional<Web::CSS::Selector::PseudoElement> pseudo_element) => (bool has_style, DeprecatedString specified_style, DeprecatedString computed_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing) + inspect_dom_node(i32 node_id, Optional<Web::CSS::Selector::PseudoElement> pseudo_element) => (bool has_style, DeprecatedString computed_style, DeprecatedString resolved_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing) get_hovered_node_id() => (i32 node_id) js_console_input(DeprecatedString js_source) =| js_console_request_messages(i32 start_index) =| |