Everywhere: Explicitly specify the size in StringView constructors

This commit moves the length calculations out to be directly on the
StringView users. This is an important step towards the goal of removing
StringView(char const*), as it moves the responsibility of calculating
the size of the string to the user of the StringView (which will prevent
naive uses causing OOB access).

1 files changed, 11 insertions, 2 deletions

diff --git a/Userland/Services/DHCPClient/DHCPv4.h b/Userland/Services/DHCPClient/DHCPv4.h
index de00f46c6d..762bc2b345 100644
--- a/Userland/Services/DHCPClient/DHCPv4.h
+++ b/Userland/Services/DHCPClient/DHCPv4.h
@@ -214,8 +214,17 @@ public:
     MACAddress const& chaddr() const { return *(MACAddress const*)&m_chaddr[0]; }
     void set_chaddr(MACAddress const& mac) { *(MACAddress*)&m_chaddr[0] = mac; }
 
-    StringView sname() const { return { (char const*)&m_sname[0] }; }
-    StringView file() const { return { (char const*)&m_file[0] }; }
+    StringView sname() const
+    {
+        char const* sname_ptr = reinterpret_cast<char const*>(&m_sname[0]);
+        return { sname_ptr, strlen(sname_ptr) };
+    }
+
+    StringView file() const
+    {
+        char const* file_ptr = reinterpret_cast<char const*>(&m_file[0]);
+        return { file_ptr, strlen(file_ptr) };
+    }
 
 private:
     NetworkOrdered<u8> m_op;