AK+Everywhere: Change URL::path() to serialize_path()

This now defaults to serializing the path with percent decoded segments
(which is what all callers expect), but has an option not to. This fixes
`file://` URLs with spaces in their paths.

The name has been changed to serialize_path() path to make it more clear
that this method will generate a new string each call (except for the
cannot_be_a_base_url() case). A few callers have then been updated to
avoid repeatedly calling this function.

1 files changed, 3 insertions, 2 deletions

diff --git a/Userland/Libraries/LibWebSocket/ConnectionInfo.cpp b/Userland/Libraries/LibWebSocket/ConnectionInfo.cpp
index a5846ad2b8..d6bc7036a4 100644
--- a/Userland/Libraries/LibWebSocket/ConnectionInfo.cpp
+++ b/Userland/Libraries/LibWebSocket/ConnectionInfo.cpp
@@ -26,10 +26,11 @@ DeprecatedString ConnectionInfo::resource_name() const
     // The "resource-name" can be constructed by concatenating the following:
     StringBuilder builder;
     // "/" if the path component is empty
-    if (m_url.path().is_empty())
+    auto path = m_url.serialize_path();
+    if (path.is_empty())
         builder.append('/');
     // The path component
-    builder.append(m_url.path());
+    builder.append(path);
     // "?" if the query component is non-empty
     if (!m_url.query().is_empty())
         builder.append('?');