diff options
| author | Kenneth Myhra <kennethmyhra@gmail.com> | 2023-02-19 10:38:20 +0100 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2023-02-22 09:55:33 +0100 |
| commit | 587cf355ed3bb6e18752129d335f0662e8354201 (patch) | |
| tree | cef62d1e626ffa7c5235adf8cf2ac736b40a9722 /Userland/Libraries/LibWeb/UIEvents | |
| parent | a401cff4e215c438e86906643e22b4334bf5b9b6 (diff) | |
| download | serenity-587cf355ed3bb6e18752129d335f0662e8354201.zip | |
LibWeb: Make factory methods of UIEvents::UIEvent fallible
This affects calls to FocusEvent::create() since FocusEvent does not
implement its own create() method.
Diffstat (limited to 'Userland/Libraries/LibWeb/UIEvents')
| -rw-r--r-- | Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp | 8 | ||||
| -rw-r--r-- | Userland/Libraries/LibWeb/UIEvents/UIEvent.h | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp b/Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp index db7b991ab5..ae896da473 100644 --- a/Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp +++ b/Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp @@ -9,14 +9,14 @@ namespace Web::UIEvents { -UIEvent* UIEvent::create(JS::Realm& realm, DeprecatedFlyString const& event_name) +WebIDL::ExceptionOr<JS::NonnullGCPtr<UIEvent>> UIEvent::create(JS::Realm& realm, DeprecatedFlyString const& event_name) { - return realm.heap().allocate<UIEvent>(realm, realm, event_name).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate<UIEvent>(realm, realm, event_name)); } -UIEvent* UIEvent::construct_impl(JS::Realm& realm, DeprecatedFlyString const& event_name, UIEventInit const& event_init) +WebIDL::ExceptionOr<JS::NonnullGCPtr<UIEvent>> UIEvent::construct_impl(JS::Realm& realm, DeprecatedFlyString const& event_name, UIEventInit const& event_init) { - return realm.heap().allocate<UIEvent>(realm, realm, event_name, event_init).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate<UIEvent>(realm, realm, event_name, event_init)); } UIEvent::UIEvent(JS::Realm& realm, DeprecatedFlyString const& event_name) diff --git a/Userland/Libraries/LibWeb/UIEvents/UIEvent.h b/Userland/Libraries/LibWeb/UIEvents/UIEvent.h index cf7ff0c106..57be8375c3 100644 --- a/Userland/Libraries/LibWeb/UIEvents/UIEvent.h +++ b/Userland/Libraries/LibWeb/UIEvents/UIEvent.h @@ -21,8 +21,8 @@ class UIEvent : public DOM::Event { WEB_PLATFORM_OBJECT(UIEvent, DOM::Event); public: - static UIEvent* create(JS::Realm&, DeprecatedFlyString const& type); - static UIEvent* construct_impl(JS::Realm&, DeprecatedFlyString const& event_name, UIEventInit const& event_init); + static WebIDL::ExceptionOr<JS::NonnullGCPtr<UIEvent>> create(JS::Realm&, DeprecatedFlyString const& type); + static WebIDL::ExceptionOr<JS::NonnullGCPtr<UIEvent>> construct_impl(JS::Realm&, DeprecatedFlyString const& event_name, UIEventInit const& event_init); virtual ~UIEvent() override; |