diff options
| author | Andreas Kling <kling@serenityos.org> | 2022-08-28 13:42:07 +0200 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2022-09-06 00:27:09 +0200 |
| commit | 6f433c86564c24d47d520cb5bdcc2209d724ac96 (patch) | |
| tree | 886a2f727782e466e99c61c628637872c1b7403f /Userland/Libraries/LibWeb/Loader | |
| parent | bb547ce1c4251e3689287eac845593398a379ca5 (diff) | |
| download | serenity-6f433c86564c24d47d520cb5bdcc2209d724ac96.zip | |
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.
There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
Diffstat (limited to 'Userland/Libraries/LibWeb/Loader')
| -rw-r--r-- | Userland/Libraries/LibWeb/Loader/FrameLoader.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp index f22b75642a..dd16be17db 100644 --- a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp +++ b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp @@ -99,8 +99,8 @@ static bool build_image_document(DOM::Document& document, ByteBuffer const& data head_element->append_child(title_element); auto basename = LexicalPath::basename(document.url().path()); - auto title_text = adopt_ref(*new DOM::Text(document, String::formatted("{} [{}x{}]", basename, bitmap->width(), bitmap->height()))); - title_element->append_child(title_text); + auto title_text = document.heap().allocate<DOM::Text>(document.realm(), document, String::formatted("{} [{}x{}]", basename, bitmap->width(), bitmap->height())); + title_element->append_child(*title_text); auto body_element = document.create_element("body").release_value(); html_element->append_child(body_element); |