diff options
author | Timothy Flynn <trflynn89@pm.me> | 2023-01-28 12:33:35 -0500 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2023-01-29 00:02:45 +0000 |
commit | 2692db869963ed10947b05f13eade5fcbd5951dc (patch) | |
tree | ef12b9e76ff4edb64571819643a92d8e6c33a2fe /Userland/Libraries/LibWeb/HTML/Location.cpp | |
parent | 1c1b902a6a0c1c7017fdc6d9748018317a554c9b (diff) | |
download | serenity-2692db869963ed10947b05f13eade5fcbd5951dc.zip |
LibJS+Everywhere: Allow Cell::initialize overrides to throw OOM errors
Note that as of this commit, there aren't any such throwers, and the
call site in Heap::allocate will drop exceptions on the floor. This
commit only serves to change the declaration of the overrides, make sure
they return an empty value, and to propagate OOM errors frm their base
initialize invocations.
Diffstat (limited to 'Userland/Libraries/LibWeb/HTML/Location.cpp')
-rw-r--r-- | Userland/Libraries/LibWeb/HTML/Location.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Userland/Libraries/LibWeb/HTML/Location.cpp b/Userland/Libraries/LibWeb/HTML/Location.cpp index 04714e5e52..d9d6ccaddb 100644 --- a/Userland/Libraries/LibWeb/HTML/Location.cpp +++ b/Userland/Libraries/LibWeb/HTML/Location.cpp @@ -35,9 +35,9 @@ void Location::visit_edges(Cell::Visitor& visitor) visitor.visit(property); } -void Location::initialize(JS::Realm& realm) +JS::ThrowCompletionOr<void> Location::initialize(JS::Realm& realm) { - Object::initialize(realm); + MUST_OR_THROW_OOM(Object::initialize(realm)); set_prototype(&Bindings::ensure_web_prototype<Bindings::LocationPrototype>(realm, "Location")); // FIXME: Implement steps 2.-4. @@ -45,6 +45,8 @@ void Location::initialize(JS::Realm& realm) // 5. Set the value of the [[DefaultProperties]] internal slot of location to location.[[OwnPropertyKeys]](). // NOTE: In LibWeb this happens before the ESO is set up, so we must avoid location's custom [[OwnPropertyKeys]]. m_default_properties.extend(MUST(Object::internal_own_property_keys())); + + return {}; } // https://html.spec.whatwg.org/multipage/history.html#relevant-document |