diff options
| author | MacDue <macdue@dueutil.tech> | 2023-01-29 19:12:00 +0100 |
|---|---|---|
| committer | Linus Groh <mail@linusgroh.de> | 2023-01-28 22:09:18 +0000 |
| commit | 890b4d79800f61450e903f1b6408431243a94793 (patch) | |
| tree | 3c882b71a7eeb89655272340fefcdcec6c9deaf5 /Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h | |
| parent | f23eba1ba806421703e05d3ce6ea456e7788e3ae (diff) | |
| download | serenity-890b4d79800f61450e903f1b6408431243a94793.zip | |
LibWeb: Replace ARIA role static FlyStrings with an enum
This replaces the FlyStrings for ARIA roles that were constructed in
a [[gnu::constructor]] with a single enum. I came across this as the
DOM inspector was crashing due to a null FlyString for an ARIA role.
After fixing that, I was confused as to why these roles were not an
enum. Looking at the spec there's a fixed list of roles and switching
from references to static strings to an enum was pretty much an
exercise in find and replace :).
No functional changes (outside of fixing the mentioned crash).
Diffstat (limited to 'Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h')
| -rw-r--r-- | Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h b/Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h index 9633a7c85b..c6d8228c92 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h +++ b/Userland/Libraries/LibWeb/HTML/HTMLOptionElement.h @@ -30,7 +30,7 @@ public: bool disabled() const; - virtual DeprecatedFlyString default_role() const override; + virtual Optional<DOM::ARIARoles::Role> default_role() const override; private: friend class Bindings::OptionConstructor; |