diff options
| author | Timothy Flynn <trflynn89@pm.me> | 2023-01-10 06:28:20 -0500 |
|---|---|---|
| committer | Andreas Kling <kling@serenityos.org> | 2023-01-10 16:08:14 +0100 |
| commit | 834202aeb9a47c544ab4e61deb813de50bc03946 (patch) | |
| tree | c120e9231fa5451b527131f6e423fac2645253bb /Userland/Libraries/LibWeb/HTML/HTMLElement.cpp | |
| parent | 7bd8fd000f3f8e92ff632be2370a279ac2309250 (diff) | |
| download | serenity-834202aeb9a47c544ab4e61deb813de50bc03946.zip | |
LibWeb: Move setting of Web object prototypes to initialize()
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
Diffstat (limited to 'Userland/Libraries/LibWeb/HTML/HTMLElement.cpp')
| -rw-r--r-- | Userland/Libraries/LibWeb/HTML/HTMLElement.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp index 35a146ac07..701699ddad 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp +++ b/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp @@ -36,7 +36,6 @@ namespace Web::HTML { HTMLElement::HTMLElement(DOM::Document& document, DOM::QualifiedName qualified_name) : Element(document, move(qualified_name)) { - set_prototype(&Bindings::cached_web_prototype(realm(), "HTMLElement")); } HTMLElement::~HTMLElement() = default; @@ -44,6 +43,8 @@ HTMLElement::~HTMLElement() = default; void HTMLElement::initialize(JS::Realm& realm) { Base::initialize(realm); + set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLElementPrototype>(realm, "HTMLElement")); + m_dataset = DOMStringMap::create(*this); } |