diff options
author | Lenny Maiorani <lenny@serenityos.org> | 2022-03-14 13:21:51 -0600 |
---|---|---|
committer | Linus Groh <mail@linusgroh.de> | 2022-03-17 17:23:49 +0000 |
commit | c37820b898cdb9689debd28f9c66c70a16d3c663 (patch) | |
tree | c376e1fadc791bf1c651da4ba0ea1411ac046581 /Userland/Libraries/LibWeb/DOM | |
parent | c0dd188c4defcba2dcae1b14510d494331134e90 (diff) | |
download | serenity-c37820b898cdb9689debd28f9c66c70a16d3c663.zip |
Libraries: Use default constructors/destructors in LibWeb
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules
"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
Diffstat (limited to 'Userland/Libraries/LibWeb/DOM')
29 files changed, 20 insertions, 81 deletions
diff --git a/Userland/Libraries/LibWeb/DOM/AbortController.cpp b/Userland/Libraries/LibWeb/DOM/AbortController.cpp index f218c5fe4e..4e92ee301e 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortController.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortController.cpp @@ -15,10 +15,6 @@ AbortController::AbortController() { } -AbortController::~AbortController() -{ -} - // https://dom.spec.whatwg.org/#dom-abortcontroller-abort void AbortController::abort(JS::Value reason) { diff --git a/Userland/Libraries/LibWeb/DOM/AbortController.h b/Userland/Libraries/LibWeb/DOM/AbortController.h index a084fbe044..dc616ecc67 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortController.h +++ b/Userland/Libraries/LibWeb/DOM/AbortController.h @@ -34,7 +34,7 @@ public: return AbortController::create(); } - virtual ~AbortController() override; + virtual ~AbortController() override = default; // https://dom.spec.whatwg.org/#dom-abortcontroller-signal NonnullRefPtr<AbortSignal> signal() const { return m_signal; } diff --git a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp index f019050513..e98893d46f 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp @@ -19,10 +19,6 @@ AbortSignal::AbortSignal() { } -AbortSignal::~AbortSignal() -{ -} - JS::Object* AbortSignal::create_wrapper(JS::GlobalObject& global_object) { return wrap(global_object, *this); diff --git a/Userland/Libraries/LibWeb/DOM/AbortSignal.h b/Userland/Libraries/LibWeb/DOM/AbortSignal.h index 180270ee34..fd45590a27 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortSignal.h +++ b/Userland/Libraries/LibWeb/DOM/AbortSignal.h @@ -37,7 +37,7 @@ public: return AbortSignal::create(); } - virtual ~AbortSignal() override; + virtual ~AbortSignal() override = default; void add_abort_algorithm(Function<void()>); diff --git a/Userland/Libraries/LibWeb/DOM/CharacterData.cpp b/Userland/Libraries/LibWeb/DOM/CharacterData.cpp index 95ce342b11..61016446af 100644 --- a/Userland/Libraries/LibWeb/DOM/CharacterData.cpp +++ b/Userland/Libraries/LibWeb/DOM/CharacterData.cpp @@ -15,10 +15,6 @@ CharacterData::CharacterData(Document& document, NodeType type, const String& da { } -CharacterData::~CharacterData() -{ -} - void CharacterData::set_data(String data) { if (m_data == data) diff --git a/Userland/Libraries/LibWeb/DOM/CharacterData.h b/Userland/Libraries/LibWeb/DOM/CharacterData.h index 82967ccc0d..329adbbea6 100644 --- a/Userland/Libraries/LibWeb/DOM/CharacterData.h +++ b/Userland/Libraries/LibWeb/DOM/CharacterData.h @@ -20,7 +20,7 @@ class CharacterData public: using WrapperType = Bindings::CharacterDataWrapper; - virtual ~CharacterData() override; + virtual ~CharacterData() override = default; const String& data() const { return m_data; } void set_data(String); diff --git a/Userland/Libraries/LibWeb/DOM/Comment.cpp b/Userland/Libraries/LibWeb/DOM/Comment.cpp index 293250d00c..8b70cf501b 100644 --- a/Userland/Libraries/LibWeb/DOM/Comment.cpp +++ b/Userland/Libraries/LibWeb/DOM/Comment.cpp @@ -15,10 +15,6 @@ Comment::Comment(Document& document, const String& data) { } -Comment::~Comment() -{ -} - // https://dom.spec.whatwg.org/#dom-comment-comment NonnullRefPtr<Comment> Comment::create_with_global_object(Bindings::WindowObject& window, String const& data) { diff --git a/Userland/Libraries/LibWeb/DOM/Comment.h b/Userland/Libraries/LibWeb/DOM/Comment.h index 2d9c4d0646..14424adb46 100644 --- a/Userland/Libraries/LibWeb/DOM/Comment.h +++ b/Userland/Libraries/LibWeb/DOM/Comment.h @@ -16,7 +16,7 @@ public: using WrapperType = Bindings::CommentWrapper; explicit Comment(Document&, const String&); - virtual ~Comment() override; + virtual ~Comment() override = default; virtual FlyString node_name() const override { return "#comment"; } diff --git a/Userland/Libraries/LibWeb/DOM/DOMEventListener.cpp b/Userland/Libraries/LibWeb/DOM/DOMEventListener.cpp index 5002a72a37..39ceba325e 100644 --- a/Userland/Libraries/LibWeb/DOM/DOMEventListener.cpp +++ b/Userland/Libraries/LibWeb/DOM/DOMEventListener.cpp @@ -9,12 +9,6 @@ #include <LibWeb/DOM/IDLEventListener.h> namespace Web::DOM { - -DOMEventListener::DOMEventListener() -{ -} -DOMEventListener::~DOMEventListener() -{ -} - +DOMEventListener::DOMEventListener() = default; +DOMEventListener::~DOMEventListener() = default; } diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index 53478cf250..ba994bc65d 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -92,9 +92,7 @@ Document::Document(const AK::URL& url) }); } -Document::~Document() -{ -} +Document::~Document() = default; void Document::removed_last_ref() { diff --git a/Userland/Libraries/LibWeb/DOM/DocumentFragment.cpp b/Userland/Libraries/LibWeb/DOM/DocumentFragment.cpp index 26c4075e8b..67dc77eea2 100644 --- a/Userland/Libraries/LibWeb/DOM/DocumentFragment.cpp +++ b/Userland/Libraries/LibWeb/DOM/DocumentFragment.cpp @@ -14,10 +14,6 @@ DocumentFragment::DocumentFragment(Document& document) { } -DocumentFragment::~DocumentFragment() -{ -} - // https://dom.spec.whatwg.org/#dom-documentfragment-documentfragment NonnullRefPtr<DocumentFragment> DocumentFragment::create_with_global_object(Bindings::WindowObject& window) { diff --git a/Userland/Libraries/LibWeb/DOM/DocumentFragment.h b/Userland/Libraries/LibWeb/DOM/DocumentFragment.h index 2d3aca8e44..c418194f20 100644 --- a/Userland/Libraries/LibWeb/DOM/DocumentFragment.h +++ b/Userland/Libraries/LibWeb/DOM/DocumentFragment.h @@ -22,7 +22,7 @@ public: static NonnullRefPtr<DocumentFragment> create_with_global_object(Bindings::WindowObject& window); explicit DocumentFragment(Document& document); - virtual ~DocumentFragment() override; + virtual ~DocumentFragment() override = default; virtual FlyString node_name() const override { return "#document-fragment"; } diff --git a/Userland/Libraries/LibWeb/DOM/DocumentType.cpp b/Userland/Libraries/LibWeb/DOM/DocumentType.cpp index 86ac846aa1..1f03de4657 100644 --- a/Userland/Libraries/LibWeb/DOM/DocumentType.cpp +++ b/Userland/Libraries/LibWeb/DOM/DocumentType.cpp @@ -13,8 +13,4 @@ DocumentType::DocumentType(Document& document) { } -DocumentType::~DocumentType() -{ -} - } diff --git a/Userland/Libraries/LibWeb/DOM/DocumentType.h b/Userland/Libraries/LibWeb/DOM/DocumentType.h index b40389ab9f..d5977a0208 100644 --- a/Userland/Libraries/LibWeb/DOM/DocumentType.h +++ b/Userland/Libraries/LibWeb/DOM/DocumentType.h @@ -24,7 +24,7 @@ public: } explicit DocumentType(Document&); - virtual ~DocumentType() override; + virtual ~DocumentType() override = default; virtual FlyString node_name() const override { return "#doctype"; } diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp index de3ac9d8bd..acfd9b07a5 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.cpp +++ b/Userland/Libraries/LibWeb/DOM/Element.cpp @@ -47,9 +47,7 @@ Element::Element(Document& document, DOM::QualifiedName qualified_name) make_html_uppercased_qualified_name(); } -Element::~Element() -{ -} +Element::~Element() = default; // https://dom.spec.whatwg.org/#dom-element-getattribute String Element::get_attribute(const FlyString& name) const diff --git a/Userland/Libraries/LibWeb/DOM/Event.h b/Userland/Libraries/LibWeb/DOM/Event.h index 80963e100d..23d25f040e 100644 --- a/Userland/Libraries/LibWeb/DOM/Event.h +++ b/Userland/Libraries/LibWeb/DOM/Event.h @@ -56,7 +56,7 @@ public: return Event::create(event_name, event_init); } - virtual ~Event() { } + virtual ~Event() = default; double time_stamp() const; diff --git a/Userland/Libraries/LibWeb/DOM/EventTarget.cpp b/Userland/Libraries/LibWeb/DOM/EventTarget.cpp index 77419de0c5..274531e5c4 100644 --- a/Userland/Libraries/LibWeb/DOM/EventTarget.cpp +++ b/Userland/Libraries/LibWeb/DOM/EventTarget.cpp @@ -37,13 +37,8 @@ namespace Web::DOM { -EventTarget::EventTarget() -{ -} - -EventTarget::~EventTarget() -{ -} +EventTarget::EventTarget() = default; +EventTarget::~EventTarget() = default; // https://dom.spec.whatwg.org/#concept-flatten-options static bool flatten_event_listener_options(Variant<EventListenerOptions, bool> const& options) diff --git a/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp b/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp index 64520f439e..c4f4bb7c63 100644 --- a/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp +++ b/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp @@ -18,9 +18,7 @@ HTMLCollection::HTMLCollection(ParentNode& root, Function<bool(Element const&)> { } -HTMLCollection::~HTMLCollection() -{ -} +HTMLCollection::~HTMLCollection() = default; Vector<NonnullRefPtr<Element>> HTMLCollection::collect_matching_elements() const { diff --git a/Userland/Libraries/LibWeb/DOM/Position.h b/Userland/Libraries/LibWeb/DOM/Position.h index 1fc5737af2..a4fe55a57e 100644 --- a/Userland/Libraries/LibWeb/DOM/Position.h +++ b/Userland/Libraries/LibWeb/DOM/Position.h @@ -15,7 +15,7 @@ namespace Web::DOM { class Position { public: - Position() { } + Position() = default; Position(Node&, unsigned offset); bool is_valid() const { return m_node; } diff --git a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp index 577eba2b2c..c1cc2f2dce 100644 --- a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp +++ b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp @@ -15,8 +15,4 @@ ProcessingInstruction::ProcessingInstruction(Document& document, const String& d { } -ProcessingInstruction::~ProcessingInstruction() -{ -} - } diff --git a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h index 5767344047..f7b1849838 100644 --- a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h +++ b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h @@ -16,7 +16,7 @@ public: using WrapperType = Bindings::ProcessingInstructionWrapper; ProcessingInstruction(Document&, const String& data, const String& target); - virtual ~ProcessingInstruction() override; + virtual ~ProcessingInstruction() override = default; virtual FlyString node_name() const override { return m_target; } diff --git a/Userland/Libraries/LibWeb/DOM/Range.cpp b/Userland/Libraries/LibWeb/DOM/Range.cpp index 9daf788987..a989de8432 100644 --- a/Userland/Libraries/LibWeb/DOM/Range.cpp +++ b/Userland/Libraries/LibWeb/DOM/Range.cpp @@ -43,10 +43,6 @@ Range::Range(Node& start_container, u32 start_offset, Node& end_container, u32 e { } -Range::~Range() -{ -} - // https://dom.spec.whatwg.org/#concept-range-root Node& Range::root() { diff --git a/Userland/Libraries/LibWeb/DOM/Range.h b/Userland/Libraries/LibWeb/DOM/Range.h index 1c84c0b34a..64047345d1 100644 --- a/Userland/Libraries/LibWeb/DOM/Range.h +++ b/Userland/Libraries/LibWeb/DOM/Range.h @@ -15,7 +15,7 @@ class Range final : public AbstractRange { public: using WrapperType = Bindings::RangeWrapper; - virtual ~Range() override; + virtual ~Range() override = default; static NonnullRefPtr<Range> create(Document&); static NonnullRefPtr<Range> create(HTML::Window&); diff --git a/Userland/Libraries/LibWeb/DOM/StaticRange.cpp b/Userland/Libraries/LibWeb/DOM/StaticRange.cpp index ec5ba26200..aadea6b36d 100644 --- a/Userland/Libraries/LibWeb/DOM/StaticRange.cpp +++ b/Userland/Libraries/LibWeb/DOM/StaticRange.cpp @@ -17,10 +17,6 @@ StaticRange::StaticRange(Node& start_container, u32 start_offset, Node& end_cont { } -StaticRange::~StaticRange() -{ -} - // https://dom.spec.whatwg.org/#dom-staticrange-staticrange ExceptionOr<NonnullRefPtr<StaticRange>> StaticRange::create_with_global_object(JS::GlobalObject&, StaticRangeInit& init) { diff --git a/Userland/Libraries/LibWeb/DOM/StaticRange.h b/Userland/Libraries/LibWeb/DOM/StaticRange.h index 9e99d0c0d1..69dfaef249 100644 --- a/Userland/Libraries/LibWeb/DOM/StaticRange.h +++ b/Userland/Libraries/LibWeb/DOM/StaticRange.h @@ -23,7 +23,7 @@ class StaticRange final : public AbstractRange { public: using WrapperType = Bindings::StaticRangeWrapper; - virtual ~StaticRange() override; + virtual ~StaticRange() override = default; static ExceptionOr<NonnullRefPtr<StaticRange>> create_with_global_object(JS::GlobalObject&, StaticRangeInit& init); diff --git a/Userland/Libraries/LibWeb/DOM/Text.cpp b/Userland/Libraries/LibWeb/DOM/Text.cpp index 22df127689..27d8783984 100644 --- a/Userland/Libraries/LibWeb/DOM/Text.cpp +++ b/Userland/Libraries/LibWeb/DOM/Text.cpp @@ -16,10 +16,6 @@ Text::Text(Document& document, const String& data) { } -Text::~Text() -{ -} - // https://dom.spec.whatwg.org/#dom-text-text NonnullRefPtr<Text> Text::create_with_global_object(Bindings::WindowObject& window, String const& data) { diff --git a/Userland/Libraries/LibWeb/DOM/Text.h b/Userland/Libraries/LibWeb/DOM/Text.h index e6bf980875..3bf0646315 100644 --- a/Userland/Libraries/LibWeb/DOM/Text.h +++ b/Userland/Libraries/LibWeb/DOM/Text.h @@ -17,7 +17,7 @@ public: using WrapperType = Bindings::TextWrapper; explicit Text(Document&, const String&); - virtual ~Text() override; + virtual ~Text() override = default; static NonnullRefPtr<Text> create_with_global_object(Bindings::WindowObject& window, String const& data); diff --git a/Userland/Libraries/LibWeb/DOM/TreeWalker.cpp b/Userland/Libraries/LibWeb/DOM/TreeWalker.cpp index f63c4a52ab..4649bfcb20 100644 --- a/Userland/Libraries/LibWeb/DOM/TreeWalker.cpp +++ b/Userland/Libraries/LibWeb/DOM/TreeWalker.cpp @@ -22,10 +22,6 @@ TreeWalker::TreeWalker(Node& root) { } -TreeWalker::~TreeWalker() -{ -} - // https://dom.spec.whatwg.org/#dom-document-createtreewalker NonnullRefPtr<TreeWalker> TreeWalker::create(Node& root, unsigned what_to_show, RefPtr<NodeFilter> filter) { diff --git a/Userland/Libraries/LibWeb/DOM/TreeWalker.h b/Userland/Libraries/LibWeb/DOM/TreeWalker.h index 0701a2b8f7..2a132fbb8a 100644 --- a/Userland/Libraries/LibWeb/DOM/TreeWalker.h +++ b/Userland/Libraries/LibWeb/DOM/TreeWalker.h @@ -20,7 +20,7 @@ public: using WrapperType = Bindings::TreeWalkerWrapper; static NonnullRefPtr<TreeWalker> create(Node& root, unsigned what_to_show, RefPtr<NodeFilter>); - virtual ~TreeWalker() override; + virtual ~TreeWalker() override = default; NonnullRefPtr<Node> current_node() const; void set_current_node(Node&); |